Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do a sequential traversal to perform the block formatting context speculation #7551

Closed
pcwalton opened this issue Sep 5, 2015 · 1 comment
Closed

Comments

@pcwalton
Copy link
Contributor

@pcwalton pcwalton commented Sep 5, 2015

Unfortunately I think we'll need to do a special sequential traversal in order to correctly handle the speculation for block formatting contexts next to floats. The reason is that it's not enough to look at your immediate children to correctly figure out the widths of floats next to you, because of the way clear and float are inherently in-order. The lack of this causes the infobox on Google.com SERPs to run into the floats. This traversal should hopefully be pretty quick, because all it has to do is to sum up preferred widths. It should be restricted to the subtrees that involve block formatting contexts next to floats.

We should figure out how to restrict the size of this subtree and measure the performance cost of this traversal carefully, because it has the potential to jeopardize our parallel layout gains due to Amdahl's Law. Another alternative if this traversal turns out to be too slow would be to just stick with the speculation we have and implement the sequential fallback when the speculation fails.

@pcwalton
Copy link
Contributor Author

@pcwalton pcwalton commented Sep 15, 2016

This is already done.

@pcwalton pcwalton closed this Sep 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.