Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

border-radius doesn't clip content #7575

Closed
paulrouget opened this issue Sep 9, 2015 · 0 comments · Fixed by #16336
Closed

border-radius doesn't clip content #7575

paulrouget opened this issue Sep 9, 2015 · 0 comments · Fixed by #16336
Assignees
@mrobinson
Labels
A-layout/uncategorized C-has-manual-testcase

Comments

@paulrouget
Copy link
Contributor 

<!DOCTYPE html>

<style>
  .blue {
    border-radius: 1000px;
    border: 5px solid blue;
    height: 200px;
    width: 200px;
    margin: 50px;
  }

  .red {
    background: red;
    width: 100%;
    height: 100%;
  }

  .overflow {
    overflow: hidden;
  }
</style>

<div class="blue">
  <div class="red"></div>
</div>

<div class="blue overflow">
  <div class="red"></div>
</div>

screen shot 2015-09-09 at 10 17 02
@paulrouget paulrouget mentioned this issue Sep 9, 2015
Closed
92 tasks
@paulrouget paulrouget mentioned this issue Sep 17, 2015
Closed
@paulrouget paulrouget mentioned this issue Feb 29, 2016
Merged
@mrobinson mrobinson self-assigned this Mar 24, 2017
mrobinson added a commit to mrobinson/servo that referenced this issue Apr 10, 2017
@mrobinson
Used shared clips for overflow:hidden and CSS clip
92eae8e 
Instead of passing down a complex clipping region to each item, used
shared clipping to handle overflow:hidden and CSS clips. In addition to
being more efficient, this should also fix quite a few issues related
to absolutely positioned elements

Fixes servo#13109.
Fixes servo#10151.
Fixes servo#7575.
mrobinson added a commit to mrobinson/servo that referenced this issue Apr 10, 2017
@mrobinson
Used shared clips for overflow:hidden and CSS clip
223b3af 
Instead of passing down a complex clipping region to each item, used
shared clipping to handle overflow:hidden and CSS clips. In addition to
being more efficient, this should also fix quite a few issues related
to absolutely positioned elements

Fixes servo#13109.
Fixes servo#10151.
Fixes servo#7575.
Fixes servo#8074.
mrobinson added a commit to mrobinson/servo that referenced this issue Apr 10, 2017
@mrobinson
Used shared clips for overflow:hidden and CSS clip
2721514 
Instead of passing down a complex clipping region to each item, used
shared clipping to handle overflow:hidden and CSS clips. In addition to
being more efficient, this should also fix quite a few issues related
to absolutely positioned elements.

One existing reftest is slightly modified to avoid tickling a quirk
with the way that WebRender rasterizes masks. We are working out how to
best express these combined masks with the API or need to. The change
does not affect the original subject of the reftest.

Fixes servo#13109.
Fixes servo#10151.
Fixes servo#7575.
Fixes servo#8074.
@mrobinson mrobinson mentioned this issue Apr 10, 2017
Merged
5 tasks
bors-servo pushed a commit that referenced this issue Apr 10, 2017
Auto merge of #16336 - mrobinson:overflow-hidden, r=<try>
7ba2a0e 
Used shared clips for overflow:hidden and CSS clip

Instead of passing down a complex clipping region to each item, used
shared clipping to handle overflow:hidden and CSS clips. In addition to
being more efficient, this should also fix quite a few issues related
to absolutely positioned elements.

One existing reftest is slightly modified to avoid tickling a quirk
with the way that WebRender rasterizes masks. We are working out how to
best express these combined masks with the API or need to. The change
does not affect the original subject of the reftest.

Fixes #13109.
Fixes #10151.
Fixes #7575.
Fixes #8074.

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #13109, #10151, #7575, #8074.

<!-- Either: -->
- [x] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16336)
<!-- Reviewable:end -->
mrobinson added a commit to mrobinson/servo that referenced this issue Apr 11, 2017
@mrobinson
Used shared clips for overflow:hidden and CSS clip
903230a 
Instead of passing down a complex clipping region to each item, used
shared clipping to handle overflow:hidden and CSS clips. In addition to
being more efficient, this should also fix quite a few issues related
to absolutely positioned elements.

One existing reftest is slightly modified to avoid tickling a quirk
with the way that WebRender rasterizes masks. We are working out how to
best express these combined masks with the API or need to. The change
does not affect the original subject of the reftest.

Fixes servo#13109.
Fixes servo#10151.
Fixes servo#7575.
Fixes servo#8074.
bors-servo pushed a commit that referenced this issue Apr 11, 2017
Auto merge of #16336 - mrobinson:overflow-hidden, r=glennw
d4ca1c9 
Used shared clips for overflow:hidden and CSS clip

Instead of passing down a complex clipping region to each item, used
shared clipping to handle overflow:hidden and CSS clips. In addition to
being more efficient, this should also fix quite a few issues related
to absolutely positioned elements.

One existing reftest is slightly modified to avoid tickling a quirk
with the way that WebRender rasterizes masks. We are working out how to
best express these combined masks with the API or need to. The change
does not affect the original subject of the reftest.

Fixes #13109.
Fixes #10151.
Fixes #7575.
Fixes #8074.

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #13109, #10151, #7575, #8074.

<!-- Either: -->
- [x] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16336)
<!-- Reviewable:end -->
mrobinson added a commit to mrobinson/servo that referenced this issue Apr 12, 2017
@mrobinson
Used shared clips for overflow:hidden and CSS clip
888aa6f 
Instead of passing down a complex clipping region to each item, used
shared clipping to handle overflow:hidden and CSS clips. In addition to
being more efficient, this should also fix quite a few issues related
to absolutely positioned elements.

One existing reftest is slightly modified to avoid tickling a quirk
with the way that WebRender rasterizes masks. We are working out how to
best express these combined masks with the API or need to. The change
does not affect the original subject of the reftest.

Fixes servo#13109.
Fixes servo#10151.
Fixes servo#7575.
Fixes servo#8074.
Fixes servo#8780.
mrobinson added a commit to mrobinson/servo that referenced this issue Apr 12, 2017
@mrobinson
Used shared clips for overflow:hidden and CSS clip
6f22182 
Instead of passing down a complex clipping region to each item, used
shared clipping to handle overflow:hidden and CSS clips. In addition to
being more efficient, this should also fix quite a few issues related
to absolutely positioned elements.

One existing reftest is slightly modified to avoid tickling a quirk
with the way that WebRender rasterizes masks. We are working out how to
best express these combined masks with the API or need to. The change
does not affect the original subject of the reftest.

Fixes servo#13109.
Fixes servo#10151.
Fixes servo#7575.
Fixes servo#8074.
Fixes servo#8780.
bors-servo pushed a commit that referenced this issue Apr 13, 2017
Auto merge of #16336 - mrobinson:overflow-hidden, r=glennw
c341a7e 
Used shared clips for overflow:hidden and CSS clip

Instead of passing down a complex clipping region to each item, used
shared clipping to handle overflow:hidden and CSS clips. In addition to
being more efficient, this should also fix quite a few issues related
to absolutely positioned elements.

One existing reftest is slightly modified to avoid tickling a quirk
with the way that WebRender rasterizes masks. We are working out how to
best express these combined masks with the API or need to. The change
does not affect the original subject of the reftest.

Fixes #13109.
Fixes #10151.
Fixes #7575.
Fixes #8074.

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #13109, #10151, #7575, #8074.

<!-- Either: -->
- [x] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16336)
<!-- Reviewable:end -->
mrobinson added a commit to mrobinson/servo that referenced this issue Apr 13, 2017
@mrobinson
Used shared clips for overflow:hidden and CSS clip
7b3abcb 
Instead of passing down a complex clipping region to each item, used
shared clipping to handle overflow:hidden and CSS clips. In addition to
being more efficient, this should also fix quite a few issues related
to absolutely positioned elements.

One existing reftest is slightly modified to avoid tickling a quirk
with the way that WebRender rasterizes masks. We are working out how to
best express these combined masks with the API or need to. The change
does not affect the original subject of the reftest.

Fixes servo#13109.
Fixes servo#10151.
Fixes servo#7575.
Fixes servo#8074.
Fixes servo#8780.
bors-servo pushed a commit that referenced this issue Apr 13, 2017
Auto merge of #16336 - mrobinson:overflow-hidden, r=<try>
df0e7b1 
Used shared clips for overflow:hidden and CSS clip

Instead of passing down a complex clipping region to each item, used
shared clipping to handle overflow:hidden and CSS clips. In addition to
being more efficient, this should also fix quite a few issues related
to absolutely positioned elements.

One existing reftest is slightly modified to avoid tickling a quirk
with the way that WebRender rasterizes masks. We are working out how to
best express these combined masks with the API or need to. The change
does not affect the original subject of the reftest.

Fixes #13109.
Fixes #10151.
Fixes #7575.
Fixes #8074.

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #13109, #10151, #7575, #8074.

<!-- Either: -->
- [x] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16336)
<!-- Reviewable:end -->
mrobinson added a commit to mrobinson/servo that referenced this issue Apr 17, 2017
@mrobinson
Used shared clips for overflow:hidden and CSS clip
766df90 
Instead of passing down a complex clipping region to each item, used
shared clipping to handle overflow:hidden and CSS clips. In addition to
being more efficient, this should also fix quite a few issues related
to absolutely positioned elements.

One existing reftest is slightly modified to avoid tickling a quirk
with the way that WebRender rasterizes masks. We are working out how to
best express these combined masks with the API or need to. The change
does not affect the original subject of the reftest.

Fixes servo#13109.
Fixes servo#10151.
Fixes servo#7575.
Fixes servo#8074.
Fixes servo#8780.
mrobinson added a commit to mrobinson/servo that referenced this issue Apr 17, 2017
@mrobinson
Used shared clips for overflow:hidden and CSS clip
4451b8a 
Instead of passing down a complex clipping region to each item, used
shared clipping to handle overflow:hidden and CSS clips. In addition to
being more efficient, this should also fix quite a few issues related
to absolutely positioned elements.

One existing reftest is slightly modified to avoid tickling a quirk
with the way that WebRender rasterizes masks. We are working out how to
best express these combined masks with the API or need to. The change
does not affect the original subject of the reftest.

Fixes servo#13109.
Fixes servo#10151.
Fixes servo#7575.
Fixes servo#8074.
Fixes servo#8780.
bors-servo pushed a commit that referenced this issue Apr 17, 2017
Auto merge of #16336 - mrobinson:overflow-hidden, r=glennw
ab7e1e2 
Used shared clips for overflow:hidden and CSS clip

Instead of passing down a complex clipping region to each item, used
shared clipping to handle overflow:hidden and CSS clips. In addition to
being more efficient, this should also fix quite a few issues related
to absolutely positioned elements.

One existing reftest is slightly modified to avoid tickling a quirk
with the way that WebRender rasterizes masks. We are working out how to
best express these combined masks with the API or need to. The change
does not affect the original subject of the reftest.

Fixes #13109.
Fixes #10151.
Fixes #7575.
Fixes #8074.

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #13109, #10151, #7575, #8074.

<!-- Either: -->
- [x] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16336)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mrobinson mrobinson

Labels
A-layout/uncategorized C-has-manual-testcase
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Used shared clips for overflow:hidden and CSS clip mrobinson/servo
4 participants
@mrobinson @jdm @pcwalton @paulrouget