Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign uprust-clipboard is GPL #7578
rust-clipboard is GPL #7578
Comments
|
Ack. We'll have to remove it unless the license is changed I think. Servo dependencies must be MPL compatible. @aweinstock314 are you interested in changing the license? |
|
@metajack me and @aweinstock314 already talked about it, I'm going to rewrite the X11 side and improve the API a little, and change the license to MPL. For the record it's GPL because the X11 code was basically taken out from xclip, while the code I have was written from scratch. My code also happens to be GPL, but I'm going to change license as well. |
|
https://github.com/conradkleinespel/rustastic-clip/ might be another option here |
|
Fixed by aweinstock314/rust-clipboard@241c3f0 |
|
We are now shipping Servo Nightly builds. I think we need to get this fixed or remove this dependency ASAP. |
|
A short term alternative would be to strip the GPL parts for now (leaving copy + paste broken on Linux) and shipping that. |
|
That would be fine to me. We absolutely cannot be linking GPL code into Servo. cc @metajack |
|
@frewsxcv Are you going to do this work? It seems like it would be acceptable to put the GPL code behind a non-default feature gate. Alternatively we could not call that code so that it's not linked in. But I'm wary of solutions that may regress without us watching if the code is not excised from rust-clipboard. |
|
My |
Remove clipboard crate to due disallowed usage of GPL code <!-- Please describe your changes on the following line: --> Fixes #7578, removing usage of rust-clipboard, which contains a disallowed dependency on GPL code. r? @metajack --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [ ] These changes fix #__ (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [x] These changes do not require tests because it's a dependency removal <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12507) <!-- Reviewable:end -->
Remove clipboard crate to due disallowed usage of GPL code <!-- Please describe your changes on the following line: --> Fixes #7578, removing usage of rust-clipboard, which contains a disallowed dependency on GPL code. r? @metajack --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [ ] These changes fix #__ (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [x] These changes do not require tests because it's a dependency removal <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12507) <!-- Reviewable:end -->
|
rust-clipboard has now been re-licensed as Apache-2.0 so clipboard support can be re-added. |
At the time of writing, rust-clipboard is licensed GPL, and servo depends on rust-clipboard.
/cc @meh @aweinstock314