Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Pattern variant of CanvasFillOrStrokeStyle #7608

Closed
jdm opened this issue Sep 12, 2015 · 3 comments
Closed

Enable Pattern variant of CanvasFillOrStrokeStyle #7608

jdm opened this issue Sep 12, 2015 · 3 comments

Comments

@jdm
Copy link
Member

@jdm jdm commented Sep 12, 2015

There's a commented out variant for dealing with patterns as part of the canvas fill/stroke APIs. It was waiting on #6157, which is now complete. Completing this task likely involves looking at what the surrounding code does for each piece of code that deals with the CanvasFillOrStrokeStyle enum and making smart choices (or asking questions if stumped!).

Code: components/script/dom/canvasrenderingcontext2d.rs

@mattnenterprise
Copy link
Contributor

@mattnenterprise mattnenterprise commented Sep 21, 2015

I would like to do this

@jdm
Copy link
Member Author

@jdm jdm commented Sep 22, 2015

@mattnenterprise I actually have a student that is intending to work on this; sorry. I appreciate that you asked first!

@0X1A
Copy link
Contributor

@0X1A 0X1A commented Oct 20, 2015

@jdm I'm up for this

@jdm jdm added the C-assigned label Oct 20, 2015
bors-servo pushed a commit that referenced this issue Oct 21, 2015
Enable Pattern variant of CanvasFillOrStrokeStyle

Enables the `Pattern` variant for the enum `CanvasFillOrStrokeStyle`

See #7608

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8104)
<!-- Reviewable:end -->
bors-servo pushed a commit that referenced this issue Oct 22, 2015
Enable Pattern variant of CanvasFillOrStrokeStyle

Enables the `Pattern` variant for the enum `CanvasFillOrStrokeStyle`

See #7608

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8104)
<!-- Reviewable:end -->
jdm added a commit to jdm/servo that referenced this issue Dec 29, 2015
@jdm jdm closed this in e6a3c16 Dec 30, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.