Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

border-width: 0.5px is painted as 1px border #7665

Closed
paulrouget opened this issue Sep 18, 2015 · 1 comment
Closed

border-width: 0.5px is painted as 1px border #7665

paulrouget opened this issue Sep 18, 2015 · 1 comment
Labels
A-gfx/rendering I-wrong An incorrect behaviour is observed.

Comments

@paulrouget
Copy link
Contributor

0 5border
@paulrouget paulrouget mentioned this issue Sep 18, 2015
Closed
92 tasks
@mbrubeck
Copy link
Contributor

This is caused by this code and many similar lines in this file that use the to_nearest_azure_* functions. These incorrectly round to the nearest px. They should instead round to the nearest device pixel.

@mbrubeck mbrubeck added A-gfx/rendering I-wrong An incorrect behaviour is observed. labels Sep 18, 2015
mbrubeck added a commit to mbrubeck/servo that referenced this issue Sep 18, 2015
@mbrubeck
Snap to screen pixels instead of px
dca76f9 
Fixes servo#7665.
@mbrubeck mbrubeck mentioned this issue Sep 18, 2015
Merged
mbrubeck added a commit to mbrubeck/servo that referenced this issue Sep 18, 2015
@mbrubeck
Snap to screen pixels instead of px
aec4409 
Fixes servo#7665.
mbrubeck added a commit to mbrubeck/servo that referenced this issue Sep 18, 2015
@mbrubeck
Snap to screen pixels instead of px
fc883c6 
Fixes servo#7665.
mbrubeck added a commit to mbrubeck/servo that referenced this issue Sep 18, 2015
@mbrubeck
Snap to screen pixels instead of px
9333f02 
Fixes servo#7665.
bors-servo pushed a commit that referenced this issue Sep 18, 2015
Auto merge of #7667 - mbrubeck:oh-snap, r=glennw
491d62c 
Snap to screen pixels instead of px

Fixes #7665. r? @glennw

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7667)
<!-- Reviewable:end -->
jdramani pushed a commit to jdramani/servo that referenced this issue Sep 18, 2015
@mbrubeck @jdramani
Snap to screen pixels instead of px
49b3b8e 
Fixes servo#7665.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-gfx/rendering I-wrong An incorrect behaviour is observed.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mbrubeck @paulrouget