Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Storage::SupportedPropertyNames #7670

Closed
jdm opened this issue Sep 18, 2015 · 12 comments
Closed

Implement Storage::SupportedPropertyNames #7670

jdm opened this issue Sep 18, 2015 · 12 comments
Labels
A-content/dom

Comments

@jdm
Copy link
Member

@jdm jdm commented Sep 18, 2015

This should return the list of all keys for this storage: https://html.spec.whatwg.org/multipage/webstorage.html#the-storage-interface:supported-property-names
@jdm jdm added the A-content/dom label Sep 18, 2015
@jdm
Copy link
Member Author

@jdm jdm commented Sep 18, 2015

Code: components/script/dom/storage.rs
@jdm
Copy link
Member Author

@jdm jdm commented Sep 18, 2015

This should make sessionStorage['foo'] equivalent to sessionStorage.foo; I would expect the former to be undefined right now.
@jdm
Copy link
Member Author

@jdm jdm commented Sep 18, 2015

Note: this was filed proactively as a task for a particular contributor to work on, so please talk with me before working on it if I have not directly suggested you should work on it.
@Ms2ger
Copy link
Contributor

@Ms2ger Ms2ger commented Sep 18, 2015

This should make sessionStorage['foo'] equivalent to sessionStorage.foo; I would expect the former to be undefined right now.

This isn't correct; it should help with Object.getOwnPropertyNames(storage), though.
@frewsxcv
Copy link
Member

@frewsxcv frewsxcv commented Sep 19, 2015

Related to #7273
@ddrmanxbxfr ddrmanxbxfr mentioned this issue Sep 21, 2015
Merged
@ddrmanxbxfr
Copy link
Contributor

@ddrmanxbxfr ddrmanxbxfr commented Sep 21, 2015

I've opened a PR for it. Implemented and done some unit test on it like @frewsxcv did for htmlproperties.

If it looks ok, I'll keep on working implementing more :).

Thanks.
@ddrmanxbxfr
Copy link
Contributor

@ddrmanxbxfr ddrmanxbxfr commented Sep 21, 2015

Oh oops @jdm I didn't read the comment of warning you before. I saw the issue as unassigned. :\

Anyways, feel free to take my pr on it if you want.
@jdm
Copy link
Member Author

@jdm jdm commented Sep 21, 2015

Ack. :( I'll figure out what to do here.
@ddrmanxbxfr
Copy link
Contributor

@ddrmanxbxfr ddrmanxbxfr commented Sep 21, 2015

There's still plenty SupportedPropertyNames to implement from here, do you want me to open issues on those before working on them @jdm ?
@jdm
Copy link
Member Author

@jdm jdm commented Sep 21, 2015

I'll claim #7695 as a replacement.
@ddrmanxbxfr
Copy link
Contributor

@ddrmanxbxfr ddrmanxbxfr commented Sep 21, 2015

@jdm Ok not touching at those then :).
bors-servo pushed a commit that referenced this issue Oct 4, 2015
bors-servo
Auto merge of #7693 - ddrmanxbxfr:StorageSupportedAttributes, r=nox
21658f8 
Implement Storage::SupportedPropertyNames

Hi guys,

This is a rough draft for issue #7670 .

It includes :
   - SupportedPropertyNames implementation
   - WPT with Object.supportedpropertynames with Local Storage and Session Storage.

The following link help me understood the issue :
http://www.w3.org/TR/webstorage/#the-storage-interface
https://html.spec.whatwg.org/multipage/infrastructure.html#supported-property-names

Thanks for looking into it.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7693)
<!-- Reviewable:end -->
bors-servo pushed a commit that referenced this issue Oct 4, 2015
bors-servo
Auto merge of #7693 - ddrmanxbxfr:StorageSupportedAttributes, r=jdm
Loading status checks…
02da3a1 
Implement Storage::SupportedPropertyNames

Hi guys,

This is a rough draft for issue #7670 .

It includes :
   - SupportedPropertyNames implementation
   - WPT with Object.supportedpropertynames with Local Storage and Session Storage.

The following link help me understood the issue :
http://www.w3.org/TR/webstorage/#the-storage-interface
https://html.spec.whatwg.org/multipage/infrastructure.html#supported-property-names

Thanks for looking into it.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7693)
<!-- Reviewable:end -->
@frewsxcv
Copy link
Member

@frewsxcv frewsxcv commented Oct 11, 2015

Completed in #7693 by @ddrmanxbxfr
@frewsxcv frewsxcv closed this Oct 11, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-content/dom
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
@jdm @Ms2ger @frewsxcv @ddrmanxbxfr
You can’t perform that action at this time.