Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only display text caret in text inputs #7756

Closed
jdm opened this issue Sep 27, 2015 · 2 comments
Closed

Only display text caret in text inputs #7756

jdm opened this issue Sep 27, 2015 · 2 comments
Labels
A-layout/inline C-assigned E-easy

Comments

@jdm
Copy link
Member

@jdm jdm commented Sep 27, 2015

tests/html/test-inputs.html shows text carets in <input type="submit"> for example :) We should adjust the code added in this PR that implemented the caret to handle this case, by making get_insertion_point_for_layout return an Option value.

Code: components/script/dom/htmlinputelement.rs
@jdm jdm mentioned this issue Sep 27, 2015
Closed
@j3parker
Copy link
Contributor

@j3parker j3parker commented Sep 27, 2015

I'll grab this
@j3parker j3parker mentioned this issue Sep 27, 2015
Merged
@jdm jdm added the C-assigned label Sep 27, 2015
bors-servo pushed a commit that referenced this issue Sep 29, 2015
bors-servo
Auto merge of #7764 - j3parker:input-caret-only-for-text, r=pcwalton
b7af011 
Only display text carets in text inputs

For #7756

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7764)
<!-- Reviewable:end -->
bors-servo pushed a commit that referenced this issue Sep 29, 2015
bors-servo
Auto merge of #7764 - j3parker:input-caret-only-for-text, r=pcwalton
b723bf8 
Only display text carets in text inputs

For #7756

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7764)
<!-- Reviewable:end -->
bors-servo pushed a commit that referenced this issue Sep 29, 2015
bors-servo
Auto merge of #7764 - j3parker:input-caret-only-for-text, r=pcwalton
Loading status checks…
0c64e4a 
Only display text carets in text inputs

For #7756

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7764)
<!-- Reviewable:end -->
@wafflespeanut
Copy link
Member

@wafflespeanut wafflespeanut commented Oct 3, 2015

#7764 closes this.
@jdm jdm closed this Oct 4, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-layout/inline C-assigned E-easy
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
@jdm @j3parker @wafflespeanut
You can’t perform that action at this time.