Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display input caret for textarea #7758

Closed
jdm opened this issue Sep 27, 2015 · 1 comment
Closed

Display input caret for textarea #7758

jdm opened this issue Sep 27, 2015 · 1 comment
Labels
A-layout/inline C-assigned E-easy

Comments

@jdm
Copy link
Member

@jdm jdm commented Sep 27, 2015

Right now it only shows up for <input>, as can be seen in tests/html/test-inputs.html vs tests/html/test_textarea_input.html. We should improve ThreadsafeLayoutNode::insertion_point to handle <textarea> too, and duplicate the machinery from htmlinputelement.rs to support it.

Code: components/script/dom/htmlinputelement.rs, components/layout/wrapper.rs
@fiji-flo
Copy link
Contributor

@fiji-flo fiji-flo commented Sep 27, 2015

I'd like to give this a try.
fiji-flo added a commit to fiji-flo/servo that referenced this issue Sep 27, 2015
@fiji-flo
display input caret for textarea. fixes servo#7758
1ca1d13
fiji-flo added a commit to fiji-flo/servo that referenced this issue Sep 27, 2015
@fiji-flo
display input caret for textarea. fixes servo#7758
e5b2a4c
@jdm jdm added the C-assigned label Sep 27, 2015
fiji-flo added a commit to fiji-flo/servo that referenced this issue Sep 30, 2015
@fiji-flo
display input caret for textarea. fixes servo#7758
fa3856b
fiji-flo added a commit to fiji-flo/servo that referenced this issue Oct 10, 2015
@fiji-flo
display input caret for textarea. fixes servo#7758
e0c284e
bors-servo pushed a commit that referenced this issue Oct 21, 2015
bors-servo
Auto merge of #7761 - fiji-flo:input_caret, r=pcwalton
Loading status checks…
af6a64e 
display input caret for textarea. fixes #7758

This adds the input caret for textareas. Although, it does not handle multiline textareas correctly. The caret gets displayed for each line.

I'll look into that but that will take more time. Some feedback on this small patch would be appreciated though.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7761)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-layout/inline C-assigned E-easy
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
@jdm @fiji-flo
You can’t perform that action at this time.