Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upEOF in CSS custom property declaration #7767
Closed
Labels
Comments
SimonSapin
added a commit
to servo/rust-cssparser
that referenced
this issue
Oct 9, 2015
Only unquoted URLs are special tokens now. Use `Parser::expect_url`. This is a [breaking-change]. The version number was incremented accordingly. This change will help with servo/servo#7767
SimonSapin
added a commit
to servo/rust-cssparser
that referenced
this issue
Oct 9, 2015
Only unquoted URLs are special tokens now. Use `Parser::expect_url`. This is a [breaking-change]. The version number was incremented accordingly. This change will help with servo/servo#7767
bors-servo
pushed a commit
to servo/rust-cssparser
that referenced
this issue
Oct 9, 2015
Treat url(<string>) as a normal functions, per spec change. Only unquoted URLs are special tokens now. Use `Parser::expect_url`. This is a [breaking-change]. The version number was incremented accordingly. This change will help with servo/servo#7767 This triggers rust-lang/rust#28934 and fails to build in the current Rust nightly, but works fine in the Rust version that Servo currently use. Hopefully that rustc bug will be fixed before we need to upgrade Rust in Servo. r? @mbrubeck <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/rust-cssparser/90) <!-- Reviewable:end -->
bors-servo
added a commit
to servo/rust-cssparser
that referenced
this issue
Nov 2, 2015
Treat url(<string>) as a normal functions, per spec change. Only unquoted URLs are special tokens now. Use `Parser::expect_url`. This is a [breaking-change]. The version number was incremented accordingly. This change will help with servo/servo#7767 This triggers rust-lang/rust#28934 and fails to build in the current Rust nightly, but works fine in the Rust version that Servo currently use. Hopefully that rustc bug will be fixed before we need to upgrade Rust in Servo. r? @mbrubeck <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/rust-cssparser/90) <!-- Reviewable:end -->
bors-servo
added a commit
to servo/rust-cssparser
that referenced
this issue
Nov 5, 2015
Treat url(<string>) as a normal functions, per spec change. Only unquoted URLs are special tokens now. Use `Parser::expect_url`. This is a [breaking-change]. The version number was incremented accordingly. This change will help with servo/servo#7767 This triggers rust-lang/rust#28934 and fails to build in the current Rust nightly, but works fine in the Rust version that Servo currently use. Hopefully that rustc bug will be fixed before we need to upgrade Rust in Servo. r? @mbrubeck <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/rust-cssparser/90) <!-- Reviewable:end -->
bors-servo
added a commit
that referenced
this issue
Nov 5, 2015
bors-servo
added a commit
that referenced
this issue
Nov 7, 2015
Fix some custom properties bugs Fix #7767. <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8343) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When the CSS input ends inside of a
{ … },[ … ],( … )block,f( … )function, or quoted string in a custom property value, all open constructs are closed implicitly but the closing markers should be appended to the value. See failing tests in:tests/wpt/mozilla/tests/css/test_variable_serialization_specified.htmltests/wpt/mozilla/tests/css/test_variable_serialization_computed.htmlThe code to change is probably in the
parse_declaration_valueandparse_declaration_value_blockfunctions incomponents/style/custom_properties.rs.I’m planning to work on this.