Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intermittent test-wpt timeout in 2dcontext/drawing-images-to-the-canvas/* and mozilla/canvas/* #7787

Closed
pcwalton opened this issue Sep 29, 2015 · 12 comments

Comments

@pcwalton
Copy link
Contributor

@pcwalton pcwalton commented Sep 29, 2015

Seen in #7778.

@mbrubeck
Copy link
Contributor

@mbrubeck mbrubeck commented Sep 29, 2015

Two other drawimage tests also timed out in that run.


/2dcontext/drawing-images-to-the-canvas/drawimage_canvas_10.html
----------------------------------------------------------------
TIMEOUT [Parent]
/2dcontext/drawing-images-to-the-canvas/drawimage_canvas_11.html
----------------------------------------------------------------
TIMEOUT [Parent]
/_mozilla/mozilla/canvas/drawimage_html_image_10.html
-----------------------------------------------------
TIMEOUT [Parent]
@frewsxcv
Copy link
Member

@frewsxcv frewsxcv commented Sep 29, 2015

Unexpected Results
==================

/2dcontext/drawing-images-to-the-canvas/drawimage_canvas_5.html
---------------------------------------------------------------
TIMEOUT [Parent]
@mbrubeck
Copy link
Contributor

@mbrubeck mbrubeck commented Sep 30, 2015

/2dcontext/drawing-images-to-the-canvas/drawimage_canvas_3.html
---------------------------------------------------------------
TIMEOUT [Parent]
@mbrubeck mbrubeck changed the title Possible intermittent timeout in 2dcontext/drawing-images-to-the-canvas/drawimage_canvas_10.html Intermittent test-wpt timeout in 2dcontext/drawing-images-to-the-canvas/* and mozilla/canvas/* Sep 30, 2015
@jdm
Copy link
Member

@jdm jdm commented Sep 30, 2015

I fear there's a recent regression behind this sudden spurt of new intermittent timeouts, if we haven't modified our build machine environments recently.

@Manishearth
Copy link
Member

@Manishearth Manishearth commented Oct 10, 2015

Getting a lot of drawimage failures (#7948)

bors-servo added a commit that referenced this issue Nov 4, 2015
Investigations for #7787

I'm just going to keep throwing stuff at try, because running directly on the builders isn't yielding results.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8314)
<!-- Reviewable:end -->
@jdm
Copy link
Member

@jdm jdm commented Nov 4, 2015

The most recent log showed that we're calling composite_if_necessary early on and setting composition_request (presumably to Headless, but I forgot to print the value). I looked, and we call composite_if_necessary with the Headless argument in two locations, despite the code suggesting that there's only one. I suspect we're getting the LoadComplete message in the compositor and this is throwing off the timing.

bors-servo added a commit that referenced this issue Nov 4, 2015
Investigations for #7787

I'm just going to keep throwing stuff at try, because running directly on the builders isn't yielding results.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8314)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue Nov 4, 2015
Investigations for #7787

I'm just going to keep throwing stuff at try, because running directly on the builders isn't yielding results.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8314)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue Nov 4, 2015
Investigations for #7787

I'm just going to keep throwing stuff at try, because running directly on the builders isn't yielding results.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8314)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue Nov 4, 2015
Investigations for #7787

I'm just going to keep throwing stuff at try, because running directly on the builders isn't yielding results.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8314)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue Nov 4, 2015
Investigations for #7787

I'm just going to keep throwing stuff at try, because running directly on the builders isn't yielding results.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8314)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue Nov 4, 2015
Investigations for #7787

I'm just going to keep throwing stuff at try, because running directly on the builders isn't yielding results.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8314)
<!-- Reviewable:end -->
@jdm
Copy link
Member

@jdm jdm commented Nov 5, 2015

According to the log in http://build.servo.org/builders/mac-rel-wpt/builds/281/steps/shell_2/logs/stdio the constellation never processes the query from the compositor. Fascinating.

@jdm
Copy link
Member

@jdm jdm commented Nov 5, 2015

Most intriguingly, chan.send(ConstellationMsg::IsReadyToSaveImage(pipeline_epochs)).unwrap(); doesn't return an error value, so apparently the constellation gets into a mode where it just stops pumping its event loop.

jdm added a commit to jdm/servo that referenced this issue Nov 5, 2015
…ts on the build machines. Continuation of investigation for servo#7787.
bors-servo added a commit that referenced this issue Nov 5, 2015
Force constellation logging when running particularly frustrating tes…

…ts on the build machines. Continuation of investigation for #7787.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8367)
<!-- Reviewable:end -->
@jdm
Copy link
Member

@jdm jdm commented Nov 6, 2015

http://build.servo.org/builders/mac-rel-wpt/builds/304/steps/shell_2/logs/stdio shows zero output from constellation even with RUST_LOG=compositing::constellation ostensibly turned on, which is extremely confusing.

@jdm
Copy link
Member

@jdm jdm commented Nov 6, 2015

Running the appropriate tests locally does show the DEBUG compositing::constellation output in the full WPT log (which is not present in the full log on the builder), which either suggests that somehow RUST_LOG is present in the execution environment (which doesn't not appear to be the case according to saltfs) or the constellation doesn't even finish starting when these tests time out :<

@jdm
Copy link
Member

@jdm jdm commented Apr 22, 2016

Hasn't been seen in months, not disabled => close.

@jdm jdm closed this Apr 22, 2016
nox added a commit to nox/servo that referenced this issue Aug 10, 2016
This was related to servo#7787 that was closed because it didn't happen for a long time.
We check whether that is the case for servo#8311 too.
nox added a commit to nox/servo that referenced this issue Aug 10, 2016
This was related to servo#7787 that was closed because it didn't happen for a long time.
We check whether that is the case for servo#8311 too.
nox added a commit to nox/servo that referenced this issue Aug 10, 2016
This was related to servo#7787 that was closed because it didn't happen for a long time.
We check whether that is the case for servo#8311 too.
samuknet added a commit to samuknet/servo that referenced this issue Sep 6, 2016
This was related to servo#7787 that was closed because it didn't happen for a long time.
We check whether that is the case for servo#8311 too.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants
You can’t perform that action at this time.