Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement form submission for <select> #7849

Closed
jdm opened this issue Oct 4, 2015 · 2 comments
Closed

Implement form submission for <select> #7849

jdm opened this issue Oct 4, 2015 · 2 comments
Labels
A-content/dom C-assigned E-easy

Comments

@jdm
Copy link
Member

@jdm jdm commented Oct 4, 2015

According to https://html.spec.whatwg.org/multipage/forms.html#constructing-the-form-data-set we're supposed to include the selected <option> values from <select> (see step 3.5). We should implemented the //Unimplemented piece in get_form_dataset related to HTMLSelectElement, by adding a method to HTMLSelectElement that fetches the required values in a vector of DOMString, and appends a FormDatum value for each one according to the specification in 3.5.

code: components/script/dom/htmlselecteelement.rs, components/script/dom/htmlformelement.rs
@6112
Copy link
Contributor

@6112 6112 commented Oct 7, 2015

I would like to work on this, along with #7850.
@jdm
Copy link
Member Author

@jdm jdm commented Oct 7, 2015

Ok!
@jdm jdm added the C-assigned label Oct 7, 2015
@6112 6112 mentioned this issue Oct 7, 2015
Merged
bors-servo added a commit that referenced this issue Nov 13, 2015
@bors-servo
Auto merge of #7919 - 6112:master, r=<try>
9671eeb 
form submission for <textarea> and <select>

Fixes #7849 and #7850.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7919)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue Dec 6, 2015
@bors-servo
Auto merge of #7919 - 6112:master, r=nox
c026668 
form submission for <textarea> and <select>

Fixes #7849 and #7850.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7919)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue Dec 30, 2015
@bors-servo
Auto merge of #7919 - 6112:master, r=nox
Loading status checks…
3d969e4 
form submission for <textarea> and <select>

Fixes #7849.
Fixes #7850.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7919)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-content/dom C-assigned E-easy
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
@jdm @6112
You can’t perform that action at this time.