Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement form submission for <textarea> #7850

Closed
jdm opened this issue Oct 4, 2015 · 2 comments
Closed

Implement form submission for <textarea> #7850

jdm opened this issue Oct 4, 2015 · 2 comments

Comments

@jdm
Copy link
Member

@jdm jdm commented Oct 4, 2015

According to https://html.spec.whatwg.org/multipage/forms.html#constructing-the-form-data-set we're supposed to include <textarea> values. There's no explicit step for this, but it's covered under 3.4 and 3.9 (and mentioned in the note at the bottom). We should implemented the //Unimplemented piece in get_form_dataset related to HTMLTextareaElement; we can use the Value method for now, and I'll file a follow up issue for ensuring that we address the specific concerns mentioned at https://html.spec.whatwg.org/multipage/forms.html#the-textarea-element:concept-textarea-raw-value-7 .

code: components/script/dom/htmltextareaelement.rs, components/script/dom/htmlformelement.rs

@6112
Copy link
Contributor

@6112 6112 commented Oct 7, 2015

I would like to work on this.

@jdm
Copy link
Member Author

@jdm jdm commented Oct 7, 2015

Great!

@jdm jdm added the C-assigned label Oct 7, 2015
bors-servo added a commit that referenced this issue Nov 13, 2015
form submission for <textarea> and <select>

Fixes #7849 and #7850.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7919)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue Dec 6, 2015
form submission for <textarea> and <select>

Fixes #7849 and #7850.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7919)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue Dec 30, 2015
form submission for <textarea> and <select>

Fixes #7849.
Fixes #7850.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7919)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.