Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upExtract <input> form data creation into a method on HTMLInputElement #7851
Labels
Comments
bors-servo
pushed a commit
that referenced
this issue
Oct 7, 2015
Refactor html form dataset collection Factor out FormDatum collection for `<input>` Improve early return logic for getting the FormDatum from an `<input>` Condense element type patterns Proposed to close #7851 <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7892) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
get_form_datasetinHTMLFormElement.rsis long method that's doing a lot of things. Part of the problem is the code for dealing with<input>, which really belongs in aget_form_datummethod onHTMLInputElementinstead.Code: components/script/dom/htmlformelement.rs, components/script/dom/htmlinputelement.rs