Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the unused data field from WebSocket #7859

Closed
jdm opened this issue Oct 5, 2015 · 0 comments
Closed

Remove the unused data field from WebSocket #7859

jdm opened this issue Oct 5, 2015 · 0 comments
Labels
A-content/dom Interacting with the DOM from web content E-less-complex Straightforward. Recommended for a new contributor. I-cleanup No impact; the issue is one of maintainability or tidiness.

Comments

@jdm
Copy link
Member

jdm commented Oct 5, 2015

If my reading is correct, the field is never modified and never read.

Code: components/script/dom/websocket.rs
@jdm jdm added A-content/dom Interacting with the DOM from web content E-less-complex Straightforward. Recommended for a new contributor. I-cleanup No impact; the issue is one of maintainability or tidiness. labels Oct 5, 2015
@r-52 r-52 mentioned this issue Oct 5, 2015
Merged
bors-servo pushed a commit that referenced this issue Oct 5, 2015
Auto merge of #7880 - romankl:websockets-data-field, r=jdm
94816bb 
remove data field from websockets

The data field is currently not used (no reads/ writes). This commit
removes this temp. field.

Ref.-Issue: #7859

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7880)
<!-- Reviewable:end -->
@Ms2ger Ms2ger closed this as completed Oct 6, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-content/dom Interacting with the DOM from web content E-less-complex Straightforward. Recommended for a new contributor. I-cleanup No impact; the issue is one of maintainability or tidiness.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jdm @Ms2ger