Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the unused data field from WebSocket #7859

Closed
jdm opened this issue Oct 5, 2015 · 0 comments
Closed

Remove the unused data field from WebSocket #7859

jdm opened this issue Oct 5, 2015 · 0 comments
Labels
A-content/dom E-easy I-cleanup

Comments

@jdm
Copy link
Member

@jdm jdm commented Oct 5, 2015

If my reading is correct, the field is never modified and never read.

Code: components/script/dom/websocket.rs
@r-52 r-52 mentioned this issue Oct 5, 2015
Merged
bors-servo pushed a commit that referenced this issue Oct 5, 2015
bors-servo
Auto merge of #7880 - romankl:websockets-data-field, r=jdm
Loading status checks…
94816bb 
remove data field from websockets

The data field is currently not used (no reads/ writes). This commit
removes this temp. field.

Ref.-Issue: #7859

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7880)
<!-- Reviewable:end -->
@Ms2ger Ms2ger closed this Oct 6, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-content/dom E-easy I-cleanup
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
@jdm @Ms2ger
You can’t perform that action at this time.