Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove fields with parsed attribute values. #7863

Open
Ms2ger opened this issue Oct 5, 2015 · 4 comments
Open

Remove fields with parsed attribute values. #7863

Ms2ger opened this issue Oct 5, 2015 · 4 comments
Labels
A-content/dom

Comments

@Ms2ger
Copy link
Contributor

@Ms2ger Ms2ger commented Oct 5, 2015

For example HTMLFontElement::color. The parsed representation should be stored in an AttrValue variant.
@Ms2ger Ms2ger added the A-content/dom label Oct 5, 2015
@frewsxcv frewsxcv mentioned this issue Oct 7, 2015
Merged
@eefriedman
Copy link
Contributor

@eefriedman eefriedman commented Oct 7, 2015

Why is this an improvement? I mean, I can understand storing the parsed representation in an AttrValue when there's an IDL getter which needs the parsed representation... but if there isn't, all you're getting out of the deal is unnecessary attribute lookups.
@Ms2ger
Copy link
Contributor Author

@Ms2ger Ms2ger commented Oct 8, 2015

Having extra fields is more complex, more likely to get out of sync, and uses more memory.
frewsxcv added a commit to frewsxcv/servo that referenced this issue Oct 29, 2015
@frewsxcv
Remove struct field for <font> 'face' attribute
c844c53 
Part of servo#7863
@frewsxcv frewsxcv mentioned this issue Oct 29, 2015
Merged
bors-servo added a commit that referenced this issue Oct 30, 2015
@bors-servo
Auto merge of #8255 - frewsxcv:rm-font-face-attribute-field, r=eefrie…
Loading status checks…
a1939b0 
…dman

Remove struct field for <font> 'face' attribute

Part of #7863

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8255)
<!-- Reviewable:end -->
@eefriedman
Copy link
Contributor

@eefriedman eefriedman commented Nov 4, 2015

Elements which still need work:

HTMLBodyElement
HTMLButtonElement
HTMLFontElement #8404
HTMLHeadingElement
HTMLInputElement (size)
HTMLTableCellElement (see also #8417)
HTMLTableElement (see also #8417)
HTMLTableRowElement #8431
HTMLTableSectionElement #8431
HTMLTextAreaElement (rows, cols) #9099
frewsxcv added a commit to frewsxcv/servo that referenced this issue Nov 8, 2015
@frewsxcv
Remove HTMLFontElement::color parsed attribute value
bff4e27 
Part of servo#7863
@frewsxcv frewsxcv mentioned this issue Nov 8, 2015
Closed
frewsxcv added a commit to frewsxcv/servo that referenced this issue Dec 30, 2015
@frewsxcv
Remove fields with parsed attribute values on HTMLTextAreaElement
54360ae 
servo#7863
@frewsxcv frewsxcv mentioned this issue Dec 30, 2015
Merged
frewsxcv added a commit to frewsxcv/servo that referenced this issue Dec 30, 2015
@frewsxcv
Remove fields with parsed attribute values on HTMLTextAreaElement
3eb585f 
servo#7863
bors-servo added a commit that referenced this issue Dec 31, 2015
@bors-servo
Auto merge of #9099 - frewsxcv:rm-parsed-attr, r=nox
Loading status checks…
5e497cf 
Remove fields with parsed attribute values on HTMLTextAreaElement

#7863

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9099)
<!-- Reviewable:end -->
frewsxcv added a commit to frewsxcv/servo that referenced this issue Dec 31, 2015
@frewsxcv
Remove parsed attribute 'bgcolor' field HTMLTableElement
7649748 
servo#7863
@frewsxcv frewsxcv mentioned this issue Dec 31, 2015
Merged
bors-servo added a commit that referenced this issue Jan 2, 2016
@bors-servo
Auto merge of #9111 - frewsxcv:rm-parsed-attr, r=nox
Loading status checks…
b1ca3d1 
Remove parsed attribute 'bgcolor' field HTMLTableElement

#7863

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9111)
<!-- Reviewable:end -->
frewsxcv added a commit to frewsxcv/servo that referenced this issue Jan 3, 2016
@frewsxcv
Remove parsed attribute 'background' field on HTMLBodyElement
1a80821 
servo#7863
jrmuizel pushed a commit to jrmuizel/gecko-cinnabar that referenced this issue Jun 12, 2017
@frewsxcv
servo: Merge #9099 - Remove fields with parsed attribute values on HT…
4f18da8 
…MLTextAreaElement (from frewsxcv:rm-parsed-attr); r=nox

servo/servo#7863

Source-Repo: https://github.com/servo/servo
Source-Revision: 5e497cf3112194e4e35776c7df97930f8ff7e153
jrmuizel pushed a commit to jrmuizel/gecko-cinnabar that referenced this issue Jun 12, 2017
@frewsxcv
servo: Merge #9111 - Remove parsed attribute 'bgcolor' field HTMLTabl…
888f3c4 
…eElement (from frewsxcv:rm-parsed-attr); r=nox

servo/servo#7863

Source-Repo: https://github.com/servo/servo
Source-Revision: b1ca3d1cdff412c5ae12113c3681f789becebabc
@nox
Copy link
Member

@nox nox commented Sep 30, 2017

There are still some such fields remaining.
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this issue Oct 1, 2019
@marco-c
servo: Merge #9099 - Remove fields with parsed attribute values on HT…
4c27cee 
…MLTextAreaElement (from frewsxcv:rm-parsed-attr); r=nox

servo/servo#7863

Source-Repo: https://github.com/servo/servo
Source-Revision: 5e497cf3112194e4e35776c7df97930f8ff7e153

UltraBlame original commit: 91150be0634dd91561bc33557f7607dc66d4777b
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this issue Oct 1, 2019
@marco-c
servo: Merge #9111 - Remove parsed attribute 'bgcolor' field HTMLTabl…
212a618 
…eElement (from frewsxcv:rm-parsed-attr); r=nox

servo/servo#7863

Source-Repo: https://github.com/servo/servo
Source-Revision: b1ca3d1cdff412c5ae12113c3681f789becebabc

UltraBlame original commit: 97251a7308bfc8138a9d4306963d771d190a95cf
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this issue Oct 1, 2019
@marco-c
servo: Merge #9099 - Remove fields with parsed attribute values on HT…
1c49ecd 
…MLTextAreaElement (from frewsxcv:rm-parsed-attr); r=nox

servo/servo#7863

Source-Repo: https://github.com/servo/servo
Source-Revision: 5e497cf3112194e4e35776c7df97930f8ff7e153

UltraBlame original commit: 91150be0634dd91561bc33557f7607dc66d4777b
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this issue Oct 1, 2019
@marco-c
servo: Merge #9111 - Remove parsed attribute 'bgcolor' field HTMLTabl…
c116eca 
…eElement (from frewsxcv:rm-parsed-attr); r=nox

servo/servo#7863

Source-Repo: https://github.com/servo/servo
Source-Revision: b1ca3d1cdff412c5ae12113c3681f789becebabc

UltraBlame original commit: 97251a7308bfc8138a9d4306963d771d190a95cf
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this issue Oct 1, 2019
@marco-c
servo: Merge #9099 - Remove fields with parsed attribute values on HT…
d606fef 
…MLTextAreaElement (from frewsxcv:rm-parsed-attr); r=nox

servo/servo#7863

Source-Repo: https://github.com/servo/servo
Source-Revision: 5e497cf3112194e4e35776c7df97930f8ff7e153

UltraBlame original commit: 91150be0634dd91561bc33557f7607dc66d4777b
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this issue Oct 1, 2019
@marco-c
servo: Merge #9111 - Remove parsed attribute 'bgcolor' field HTMLTabl…
3b48c55 
…eElement (from frewsxcv:rm-parsed-attr); r=nox

servo/servo#7863

Source-Repo: https://github.com/servo/servo
Source-Revision: b1ca3d1cdff412c5ae12113c3681f789becebabc

UltraBlame original commit: 97251a7308bfc8138a9d4306963d771d190a95cf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-content/dom
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
@Ms2ger @nox @eefriedman
You can’t perform that action at this time.