Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iframe: hovering the iframe doesn't un-hover parent document nodes #7865

Closed
paulrouget opened this issue Oct 5, 2015 · 3 comments
Closed
Assignees
Labels
A-constellation Involves the constellation A-content/dom Interacting with the DOM from web content

Comments

@paulrouget
Copy link
Contributor

In this example, hovering the div turns it blue. Then moving the cursor to the iframe without leaving the div won't turn it back to red.

<style>
  div {
    width: 100px;
    height: 100px;
    background: red;
  }

  div:hover {
    background: blue;
  }

  iframe {
    margin: 10px;
    width: 600px;
    height: 300px;
    border-width: 0;
  }
</style>

<div></div>

<iframe mozbrowser remote src='http://google.com'></iframe>
@jdm jdm added the A-content/dom Interacting with the DOM from web content label Oct 5, 2015
@jdm
Copy link
Member

jdm commented Oct 5, 2015

I'm pretty sure this is due to the new mouse move event being sent to the iframe's script task, rather than the parent's so the code in Document::handle_mouse_move_event never sees the list of currently-hovered elements that require checking. We might need to store the pipeline id that received the last mouse move event in the constellation/compositor and ensure that we send a mouse move event to that as well if it's different than the current one.

@jdm jdm added the A-constellation Involves the constellation label Oct 5, 2015
@jdm jdm self-assigned this Oct 5, 2015
@paulrouget
Copy link
Contributor Author

@jdm are you still looking at this? Does that depend on @mrobinson work?

@jdm
Copy link
Member

jdm commented Oct 19, 2015

I forgot about this and haven't done any investigation beyond the original comment.

jdm added a commit to jdm/servo that referenced this issue Nov 4, 2015
bors-servo pushed a commit that referenced this issue Nov 6, 2015
Send mouse move events to the the previous layer when directing event…

…s to a new one for the first time. Resolves #7865.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8326)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-constellation Involves the constellation A-content/dom Interacting with the DOM from web content
Projects
None yet
Development

No branches or pull requests

2 participants