Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dom_class argument to do_create_interface_objects could be Option<&'static DOMClass> #7942

Closed
Ms2ger opened this issue Oct 9, 2015 · 1 comment
Closed

dom_class argument to do_create_interface_objects could be Option<&'static DOMClass> #7942

Ms2ger opened this issue Oct 9, 2015 · 1 comment
Labels
A-content/bindings E-easy I-refactor

Comments

@Ms2ger
Copy link
Contributor

@Ms2ger Ms2ger commented Oct 9, 2015

This would more clearly document what it expects.

This will involve changing the signature in components/script/dom/bindings/utils.rs and the caller in components/script/dom/bindings/codegen/CodegenRust.py.
@kunitsyn
Copy link
Contributor

@kunitsyn kunitsyn commented Oct 9, 2015

I think I've done it. Please see #7948.
bors-servo pushed a commit that referenced this issue Oct 10, 2015
bors-servo
Auto merge of #7948 - kunitsyn:master, r=Manishearth
d78d3e3 
Changed dom_class type to Option<&'static DOMClass> to fix #7942

I have a feeling that converting `Option<&T>` to `*const libc::c_void` could be less explicit.
Was there any way to do it shorter?

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7948)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-content/bindings E-easy I-refactor
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
@Ms2ger @kunitsyn
You can’t perform that action at this time.