Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upOnly pass user agent to HTTP loader factory #7968
Closed
Labels
Comments
|
I think I may have an idea on how to do this, I can give it a try. |
bors-servo
pushed a commit
that referenced
this issue
Oct 13, 2015
Removed user agent parameter from being unnecessarily passed #7968 <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8004) <!-- Reviewable:end -->
jrmuizel
pushed a commit
to jrmuizel/gecko-cinnabar
that referenced
this issue
Jun 12, 2017
…arily passed (from craftytrickster:user-agent/#7968); r=jdm servo/servo#7968 Source-Repo: https://github.com/servo/servo Source-Revision: bc58cd2de05b371f641051eb1038cd29e36bbb01
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this issue
Sep 30, 2019
…arily passed (from craftytrickster:user-agent/#7968); r=jdm servo/servo#7968 Source-Repo: https://github.com/servo/servo Source-Revision: bc58cd2de05b371f641051eb1038cd29e36bbb01 UltraBlame original commit: 60b370a29e82858fe6d932fa6df50c1a2db3e821
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this issue
Oct 1, 2019
…arily passed (from craftytrickster:user-agent/#7968); r=jdm servo/servo#7968 Source-Repo: https://github.com/servo/servo Source-Revision: bc58cd2de05b371f641051eb1038cd29e36bbb01 UltraBlame original commit: 60b370a29e82858fe6d932fa6df50c1a2db3e821
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this issue
Oct 1, 2019
…arily passed (from craftytrickster:user-agent/#7968); r=jdm servo/servo#7968 Source-Repo: https://github.com/servo/servo Source-Revision: bc58cd2de05b371f641051eb1038cd29e36bbb01 UltraBlame original commit: 60b370a29e82858fe6d932fa6df50c1a2db3e821
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The user agent string is only useful for HTTP requests, but we're passing it to every resource loader factory. We can treat it like the other HTTP-only data (hsts_list, cookie_storage, etc.) in
ResourceManager::loadand clean up the other resources loaders that don't use it (see the_user_agentargument in thefrom_factoryfunction.Code: components/net/resource_task.rs