Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure our naming is vertical-writing-direction clean #799

Closed
pcwalton opened this issue Aug 27, 2013 · 3 comments
Closed

Make sure our naming is vertical-writing-direction clean #799

pcwalton opened this issue Aug 27, 2013 · 3 comments

Comments

@pcwalton
Copy link
Contributor

@pcwalton pcwalton commented Aug 27, 2013

For vertical writing direction, block layout goes left-to-right and inline goes top-to-bottom. We should not bake in assumptions about top-to-bottom and left-to-right/right-to-left into our naming.

@SimonSapin
Copy link
Member

@SimonSapin SimonSapin commented Aug 27, 2013

As I wrote on the dev-servo mailing list:

Even if the actual feature is not a priority, it might be easier to rewrite the layout code to use logical keywords (eg. measure/extent instead of width/height) while we don’t have much layout code.

http://dev.w3.org/csswg/css-writing-modes/
http://dev.w3.org/csswg/css-writing-modes/#abstract-box

This was referenced Dec 11, 2013
@jdm
Copy link
Member

@jdm jdm commented Oct 21, 2014

@SimonSapin This is fixed after your changes, yes?

@SimonSapin
Copy link
Member

@SimonSapin SimonSapin commented Oct 21, 2014

Yes, there is still related work to do, but the naming should be good now.

@SimonSapin SimonSapin closed this Oct 21, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.