Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a tidy check for single-page HTML specification links #7998

Closed
jdm opened this issue Oct 13, 2015 · 2 comments
Closed

Add a tidy check for single-page HTML specification links #7998

jdm opened this issue Oct 13, 2015 · 2 comments
Labels
A-mach C-assigned There is someone working on resolving the issue E-less-complex Straightforward. Recommended for a new contributor. L-python Python is required

Comments

@jdm
Copy link
Member

jdm commented Oct 13, 2015

We can prevent the need for future PRs like #7997 by checking for such links automatically as part of ./mach test-tidy.

Code: python/tidy.py
@jdm jdm added E-less-complex Straightforward. Recommended for a new contributor. A-mach L-python Python is required labels Oct 13, 2015
@jdm jdm mentioned this issue Oct 13, 2015
Merged
@gilles-leblanc
Copy link
Contributor

I'd like to have a look at this one please.

@jdm
Copy link
Member Author

jdm commented Oct 14, 2015

Go for it!

@jdm jdm added the C-assigned There is someone working on resolving the issue label Oct 14, 2015
gilles-leblanc added a commit to gilles-leblanc/servo that referenced this issue Oct 16, 2015
@gilles-leblanc
Adds a tidy check for single-page HTML specification links
d991497 
Flags links to the single-page WHATWG specification and suggests the URL
for the multi page one.

Fixes servo#7998
@gilles-leblanc gilles-leblanc mentioned this issue Oct 16, 2015
Merged
bors-servo pushed a commit that referenced this issue Oct 16, 2015
Auto merge of #8044 - gilles-leblanc:issue-7998, r=Manishearth
36998cd 
Adds a tidy check for single-page HTML specification links

Flags links to the single-page WHATWG specification and suggests the URL
for the multi page one.

Fixes #7998

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8044)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-mach C-assigned There is someone working on resolving the issue E-less-complex Straightforward. Recommended for a new contributor. L-python Python is required
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jdm @gilles-leblanc