Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign up"position: fixed" list-item missing bullet #8001
Open
Comments
|
The li tag is never closed after the x. I haven't tried to reproduce this yet since I am not at my computer, but is it possible that closing the li will fix this? <li style="position: fixed">x |
|
No, the HTML parser should close that tag implicitly when it sees the |
|
Good to know, thank you. |
|
I think I may have some time to look into this one |
|
I was looking at this today, and as eefriedman suggested, the pattern matching looked incorrect to me as well. I made a change in my own branch as seen above. Prior to my change, the list item node was always getting matched and called with build_flow_for_block instead of with build_flow_for_list_item. Nevertheless, I still have not been able to figure out why the bullet isn't appearing on screen. What is also strange to me is that in the I'll have to investigate more. If I am missing anything obvious here, I'm always open to suggestions! |
|
I took a brief look; it's possible that the we're properly constructing the bullet, but not positioning/drawing it correctly. Does |
|
When I added |
|
Okay, that makes sense... the difference happens at servo/components/layout/construct.rs Line 1224 in 32daa17 inside bullet uses much less special-case code.
Maybe try playing with |
|
Thanks for the pointer, I hope to have time to look at this later |
|
I can't seem to figure this out. I notice that in |
|
Could you run with -Z dump-flow-tree,dump-display-list for both the inside and outside case, and paste that information here? I wonder if the layer size is incorrect for the outside case or something like that. |
|
I took a look with craftytrickster/servo@be54c80; there's multiple things going wrong here:
|
|
It's probably worth submitting a PR just to fix the |
|
Thanks for placing the summary. I am still new to Rust and Servo, so it is good to get additional insight. I can do display tree / list output when I get home tonight. As for the PR, I if it is helpful, I can at least open it now. |
|
Outside (bullet point is missing) |
|
Inside (bullet point is present) |
bors-servo
added a commit
that referenced
this issue
Oct 27, 2015
Made block type pattern match less inclusive Given the comments above the match statement, it seems that fixed-pos check should match only block elements in this case. Doing this change seems to partially resolve the issue where list items with `position:fixed;` styling are not displaying their bullet points. This change only resolves the issue for list items with `list-style-position: inside`, outside positioning is still not functioning correctly. #8001 (comment) <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8129) <!-- Reviewable:end -->
bors-servo
added a commit
that referenced
this issue
Oct 27, 2015
Made block type pattern match less inclusive Given the comments above the match statement, it seems that fixed-pos check should match only block elements in this case. Doing this change seems to partially resolve the issue where list items with `position:fixed;` styling are not displaying their bullet points. This change only resolves the issue for list items with `list-style-position: inside`, outside positioning is still not functioning correctly. #8001 (comment) <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8129) <!-- Reviewable:end -->
jrmuizel
pushed a commit
to jrmuizel/gecko-cinnabar
that referenced
this issue
Jun 12, 2017
…om craftytrickster:pos-fixed-list-item); r=glennw Given the comments above the match statement, it seems that fixed-pos check should match only block elements in this case. Doing this change seems to partially resolve the issue where list items with `position:fixed;` styling are not displaying their bullet points. This change only resolves the issue for list items with `list-style-position: inside`, outside positioning is still not functioning correctly. servo/servo#8001 (comment) Source-Repo: https://github.com/servo/servo Source-Revision: 381317f658bbfd66674cc1e92b27c86503ca7d31
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this issue
Oct 1, 2019
…om craftytrickster:pos-fixed-list-item); r=glennw Given the comments above the match statement, it seems that fixed-pos check should match only block elements in this case. Doing this change seems to partially resolve the issue where list items with `position:fixed;` styling are not displaying their bullet points. This change only resolves the issue for list items with `list-style-position: inside`, outside positioning is still not functioning correctly. servo/servo#8001 (comment) Source-Repo: https://github.com/servo/servo Source-Revision: 381317f658bbfd66674cc1e92b27c86503ca7d31 UltraBlame original commit: 21b579e9cc0bb86384d7e4889aa17912c49d04b9
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this issue
Oct 1, 2019
…om craftytrickster:pos-fixed-list-item); r=glennw Given the comments above the match statement, it seems that fixed-pos check should match only block elements in this case. Doing this change seems to partially resolve the issue where list items with `position:fixed;` styling are not displaying their bullet points. This change only resolves the issue for list items with `list-style-position: inside`, outside positioning is still not functioning correctly. servo/servo#8001 (comment) Source-Repo: https://github.com/servo/servo Source-Revision: 381317f658bbfd66674cc1e92b27c86503ca7d31 UltraBlame original commit: 21b579e9cc0bb86384d7e4889aa17912c49d04b9
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this issue
Oct 1, 2019
…om craftytrickster:pos-fixed-list-item); r=glennw Given the comments above the match statement, it seems that fixed-pos check should match only block elements in this case. Doing this change seems to partially resolve the issue where list items with `position:fixed;` styling are not displaying their bullet points. This change only resolves the issue for list items with `list-style-position: inside`, outside positioning is still not functioning correctly. servo/servo#8001 (comment) Source-Repo: https://github.com/servo/servo Source-Revision: 381317f658bbfd66674cc1e92b27c86503ca7d31 UltraBlame original commit: 21b579e9cc0bb86384d7e4889aa17912c49d04b9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Testcase:
The addition of "position: fixed" in this testcase shouldn't affect the rendering at all. Probably easy to fix, unless there's some complication I'm missing; see
servo/components/layout/construct.rs
Line 1474 in 69db834