Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move the `app_units` crate into a repository of its own #8012

Closed
Ms2ger opened this issue Oct 14, 2015 · 7 comments
Closed

Move the `app_units` crate into a repository of its own #8012

Ms2ger opened this issue Oct 14, 2015 · 7 comments
Assignees
@frewsxcv
Labels
A-infrastructure I-refactor

Comments

@Ms2ger
Copy link
Contributor

@Ms2ger Ms2ger commented Oct 14, 2015

The files in there should live directly in components/app_units/.
creativcoder added a commit to creativcoder/servo that referenced this issue Oct 14, 2015
@creativcoder
relocation from src to app units servo#8012
9b4b357
@jdm
Copy link
Member

@jdm jdm commented Oct 14, 2015

This doesn't seem like the right solution to me, since it makes it impossible to publish changes to cargo.
creativcoder added a commit to creativcoder/servo that referenced this issue Oct 14, 2015
@creativcoder
relocation from src to app units servo#8012
4c394f0
@frewsxcv frewsxcv added the C-assigned label Oct 14, 2015
creativcoder added a commit to creativcoder/servo that referenced this issue Oct 14, 2015
@creativcoder
relocation from src to app units servo#8012
ff20b37
creativcoder added a commit to creativcoder/servo that referenced this issue Oct 14, 2015
@creativcoder
relocation from src to app units servo#8012
6c77134
creativcoder added a commit to creativcoder/servo that referenced this issue Oct 14, 2015
@creativcoder
relocation from src to app units servo#8012
877ff9f
@Ms2ger Ms2ger changed the title `components/app_units/src/` should not exist Move the `app_units` crate into a repository of its own Oct 14, 2015
@Manishearth
Copy link
Member

@Manishearth Manishearth commented Oct 14, 2015

@jdm You can set a path in the Cargo.toml, Cargo packages don't need to have a src dir
@Ms2ger
Copy link
Contributor Author

@Ms2ger Ms2ger commented Oct 14, 2015

You're right, this isn't the correct solution. This crate should get its own repo, so that it gets tested and published in isolation.
@frewsxcv frewsxcv mentioned this issue Oct 14, 2015
Merged
@frewsxcv frewsxcv self-assigned this Oct 14, 2015
@frewsxcv
Copy link
Member

@frewsxcv frewsxcv commented Oct 14, 2015

Opened a PR servo/app_units#1 . I have no preferences whatsover for the repository name. I just chose 'app_units' because that's what the Cargo.toml already had specified.
frewsxcv added a commit to frewsxcv/servo that referenced this issue Oct 14, 2015
@frewsxcv
Remove 'app_units' component from tree
98c621e 
Part of servo#8012
@frewsxcv frewsxcv mentioned this issue Oct 14, 2015
Merged
@frewsxcv
Copy link
Member

@frewsxcv frewsxcv commented Oct 14, 2015

Also opened a PR to remove it from the tree #8025
bors-servo pushed a commit to servo/app_units that referenced this issue Oct 17, 2015
bors-servo
Auto merge of #1 - servo:init, r=Manishearth,frewsxcv
Loading status checks…
92b5f1d 
Initial commit of app_units contents

servo/servo#8012
@frewsxcv
Copy link
Member

@frewsxcv frewsxcv commented Oct 18, 2015

Update: servo/app_units#1 has merged. Just waiting on #8025 to get reviewed before this issue can be closed.
bors-servo pushed a commit that referenced this issue Oct 19, 2015
bors-servo
Auto merge of #8025 - frewsxcv:remove-app-units-from-tree, r=nox
b36484f 
Remove 'app_units' component from tree

Part of #8012

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8025)
<!-- Reviewable:end -->
bors-servo pushed a commit that referenced this issue Oct 19, 2015
bors-servo
Auto merge of #8025 - frewsxcv:remove-app-units-from-tree, r=nox
936713e 
Remove 'app_units' component from tree

Part of #8012

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8025)
<!-- Reviewable:end -->
bors-servo pushed a commit that referenced this issue Oct 19, 2015
bors-servo
Auto merge of #8025 - frewsxcv:remove-app-units-from-tree, r=nox
Loading status checks…
eeffa79 
Remove 'app_units' component from tree

Part of #8012

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8025)
<!-- Reviewable:end -->
@frewsxcv
Copy link
Member

@frewsxcv frewsxcv commented Oct 19, 2015

servo/app_units#1 and #8025 have merged. This is finished.
@frewsxcv frewsxcv closed this Oct 19, 2015
@Ms2ger Ms2ger added A-infrastructure and removed A-cargo labels Jan 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@frewsxcv frewsxcv

Labels
A-infrastructure I-refactor
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
@jdm @Ms2ger @frewsxcv @Manishearth
You can’t perform that action at this time.