Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Github diff highlighting does not cover entire line #8072

Open
dzbarsky opened this issue Oct 18, 2015 · 2 comments
Open

Github diff highlighting does not cover entire line #8072

dzbarsky opened this issue Oct 18, 2015 · 2 comments

Comments

@dzbarsky
Copy link
Member

@dzbarsky dzbarsky commented Oct 18, 2015

At dzbarsky@c0a0a01 the dark green highlight does not cover the top few pixels of the text in Servo. (Top is servo zoomed in, bottom is Firefox zoomed in).

screen shot 2015-10-18 at 2 45 56 pm

@nox
Copy link
Member

@nox nox commented Sep 30, 2017

This is still true.

@jdm jdm added the C-reproduced label Sep 30, 2017
@jdm
Copy link
Member

@jdm jdm commented Sep 30, 2017

<!DOCTYPE html>
<html
  <head>
    <style>
      td { background-color: #e6ffed; }
      .blob-code-inner { font-family: Menlo; font-size: 12px; }
      .x { background-color: #acf2bd; }
    </style>
  </head>
  <body>
    <table>
      <tr>
        <td>
          <span class="blob-code-inner"><span class="x">map(|result| </span>CalcValueNode</span>
        </td>
      </tr>
    </table>
  </body>
</html>

It's the Menlo font in particular that seems to make this appear.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.