Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

`query_selector_iter` no longer needs to be unsafe #8078

Closed
Ms2ger opened this issue Oct 19, 2015 · 6 comments
Closed

`query_selector_iter` no longer needs to be unsafe #8078

Ms2ger opened this issue Oct 19, 2015 · 6 comments
Labels
A-content/dom C-assigned E-easy I-safety

Comments

@Ms2ger
Copy link
Contributor

@Ms2ger Ms2ger commented Oct 19, 2015

At least, I don't think so. CCing @Manishearth to confirm.
@Manishearth
Copy link
Member

@Manishearth Manishearth commented Oct 19, 2015

This is correct.
@nox nox added the E-easy label Oct 19, 2015
@TileHalo
Copy link
Contributor

@TileHalo TileHalo commented Oct 19, 2015

I'd like to fix this if its ok.
@Manishearth
Copy link
Member

@Manishearth Manishearth commented Oct 19, 2015

Sure! Let me know if you need help.
@TileHalo
Copy link
Contributor

@TileHalo TileHalo commented Oct 20, 2015

Should I also delete comments that tells block using 'query_selector_iter' is safe?
@Manishearth
Copy link
Member

@Manishearth Manishearth commented Oct 20, 2015

Yep!
@TileHalo TileHalo mentioned this issue Oct 20, 2015
Merged
bors-servo pushed a commit that referenced this issue Oct 20, 2015
bors-servo
Auto merge of #8095 - TileHalo:foo, r=Ms2ger
Loading status checks…
25d3c2b 
Removed unsafe from 'query_selector_iter'

Fixing #8078.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8095)
<!-- Reviewable:end -->
@nox
Copy link
Member

@nox nox commented Oct 20, 2015

#8095
@nox nox closed this Oct 20, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-content/dom C-assigned E-easy I-safety
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
@Ms2ger @nox @Manishearth @TileHalo
You can’t perform that action at this time.