iframe not painted anymore after navigation (regression c72d0c2) #8081

paulrouget · 2015-10-19T12:58:20Z

Since commit c72d0c2, clicking a link in a iframe turns the iframe white.

I believe the iframe is loaded but not painted (we get load events).

paulrouget · 2015-10-19T12:59:22Z

/cc @pcwalton

glennw · 2015-10-19T19:24:48Z

I'm almost certain this will be the same as the iframe flickering.

paulrouget · 2015-10-20T08:09:02Z

I'm almost certain this will be the same as the iframe flickering.

Apparently not.

glennw · 2015-10-20T08:12:28Z

:( OK, I'll take a look at this tomorrow if @pcwalton doesn't get to it first.

glennw · 2015-10-21T03:32:51Z

I had a brief look at this but didn't really get anywhere - after navigation it seems to get the main pipeline listed twice in the layer tree, and the iframe layers are not present. @pcwalton are you able to take a look at this one? It seems to have started happening after c72d0c2.

metajack · 2015-11-21T05:21:55Z

@pcwalton @glennw It's a month later now. Can you both discuss and figure out who can tackle this?

glennw · 2015-11-22T20:46:44Z

@pcwalton said he'll look into it this week :)


        When an iframe loads a new page, dirty and reflow it so that the layout

fragment will pick up the new subpage ID. This is necessary to make its new contents show up! Closes servo#8081.


        When an iframe loads a new page, dirty and reflow it so that the layout

fragment will pick up the new subpage ID. This is necessary to make its new contents show up! Closes servo#8081.


        compositing: Fix a couple of bugs preventing iframes from displaying

after navigation. The first bug is that iframes were not reflowed in their parent DOM when the child page navigated. This is fixed by simply having the constellation notify the script thread in question when the navigation occurs. The second bug is that the compositor was unable to adjust the pipeline for existing iframe layers. This is fixed by adding logic to do that. Closes servo#8081.


        compositing: Fix a couple of bugs that prevented iframes from painting

after navigation. The first bug was that iframes were not reflowed in their parent DOM when the child page navigated. This is fixed by simply having the constellation notify the appropriate script thread when navigation occurs. The second bug was that the compositor was unable to adjust the pipeline for existing iframe layers, only new ones. This patch adds logic to do that. Closes servo#8081.


        compositing: Fix a couple of bugs that prevented iframes from painting

after navigation. The first bug was that iframes were not reflowed in their parent DOM when the child page navigated. This is fixed by simply having the constellation notify the appropriate script thread when navigation occurs. The second bug was that the compositor was unable to adjust the pipeline for existing iframe layers, only new ones. This patch adds logic to do that. Closes servo#8081.


        compositing: Fix a couple of bugs that prevented iframes from painting

after navigation. The first bug was that iframes were not reflowed in their parent DOM when the child page navigated. This is fixed by simply having the constellation notify the appropriate script thread when navigation occurs. The second bug was that the compositor was unable to adjust the pipeline for existing iframe layers, only new ones. This patch adds logic to do that. Closes servo#8081.


        compositing: Fix a couple of bugs that prevented iframes from painting

after navigation. The first bug was that iframes were not reflowed in their parent DOM when the child page navigated. This is fixed by simply having the constellation notify the appropriate script thread when navigation occurs. The second bug was that the compositor was unable to adjust the pipeline for existing iframe layers, only new ones. This patch adds logic to do that. Closes servo#8081.


        compositing: Fix a couple of bugs that prevented iframes from painting

after navigation. The first bug was that iframes were not reflowed in their parent DOM when the child page navigated. This is fixed by simply having the constellation notify the appropriate script thread when navigation occurs. The second bug was that the compositor was unable to adjust the pipeline for existing iframe layers, only new ones. This patch adds logic to do that. Closes servo#8081.


        Auto merge of #9421 - jdm:iframe-painting-after-navigation-redux, r=p…

…cwalton compositing: Fix a couple of bugs that prevented iframes from painting after navigation. The first bug was that iframes were not reflowed in their parent DOM when the child page navigated. This is fixed by simply having the constellation notify the appropriate script thread when navigation occurs. The second bug was that the compositor was unable to adjust the pipeline for existing iframe layers, only new ones. This patch adds logic to do that. The third bug was that we have ad-hoc reflow calls throughout script/, and we didn't trigger any reflow from the code that dispatches the `load` event for the iframe so the test for the first two issues would always time out. The second commit adds another reflow call to do that, and also bites the bullet and adds a catch-all reflow (which does nothing if there's no dirty nodes in the document) at the return to the event loop. Closes #8081. Extension of #9285.  [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9421)


        compositing: Fix a couple of bugs that prevented iframes from painting

after navigation. The first bug was that iframes were not reflowed in their parent DOM when the child page navigated. This is fixed by simply having the constellation notify the appropriate script thread when navigation occurs. The second bug was that the compositor was unable to adjust the pipeline for existing iframe layers, only new ones. This patch adds logic to do that. Closes servo#8081.


        Auto merge of #9421 - jdm:iframe-painting-after-navigation-redux, r=jdm

compositing: Fix a couple of bugs that prevented iframes from painting after navigation. The first bug was that iframes were not reflowed in their parent DOM when the child page navigated. This is fixed by simply having the constellation notify the appropriate script thread when navigation occurs. The second bug was that the compositor was unable to adjust the pipeline for existing iframe layers, only new ones. This patch adds logic to do that. The third bug was that we have ad-hoc reflow calls throughout script/, and we didn't trigger any reflow from the code that dispatches the `load` event for the iframe so the test for the first two issues would always time out. The second commit adds another reflow call to do that, and also bites the bullet and adds a catch-all reflow (which does nothing if there's no dirty nodes in the document) at the return to the event loop. Closes #8081. Extension of #9285.  [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9421)


        compositing: Fix a couple of bugs that prevented iframes from painting

after navigation. The first bug was that iframes were not reflowed in their parent DOM when the child page navigated. This is fixed by simply having the constellation notify the appropriate script thread when navigation occurs. The second bug was that the compositor was unable to adjust the pipeline for existing iframe layers, only new ones. This patch adds logic to do that. Closes servo#8081.


        Auto merge of #9421 - jdm:iframe-painting-after-navigation-redux, r=jdm

compositing: Fix a couple of bugs that prevented iframes from painting after navigation. The first bug was that iframes were not reflowed in their parent DOM when the child page navigated. This is fixed by simply having the constellation notify the appropriate script thread when navigation occurs. The second bug was that the compositor was unable to adjust the pipeline for existing iframe layers, only new ones. This patch adds logic to do that. The third bug was that we have ad-hoc reflow calls throughout script/, and we didn't trigger any reflow from the code that dispatches the `load` event for the iframe so the test for the first two issues would always time out. The second commit adds another reflow call to do that, and also bites the bullet and adds a catch-all reflow (which does nothing if there's no dirty nodes in the document) at the return to the event loop. Closes #8081. Extension of #9285.  [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9421)


        Auto merge of #9421 - jdm:iframe-painting-after-navigation-redux, r=jdm

compositing: Fix a couple of bugs that prevented iframes from painting after navigation. The first bug was that iframes were not reflowed in their parent DOM when the child page navigated. This is fixed by simply having the constellation notify the appropriate script thread when navigation occurs. The second bug was that the compositor was unable to adjust the pipeline for existing iframe layers, only new ones. This patch adds logic to do that. The third bug was that we have ad-hoc reflow calls throughout script/, and we didn't trigger any reflow from the code that dispatches the `load` event for the iframe so the test for the first two issues would always time out. The second commit adds another reflow call to do that, and also bites the bullet and adds a catch-all reflow (which does nothing if there's no dirty nodes in the document) at the return to the event loop. Closes #8081. Extension of #9285.  [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9421)


        Auto merge of #9421 - jdm:iframe-painting-after-navigation-redux, r=jdm

compositing: Fix a couple of bugs that prevented iframes from painting after navigation. The first bug was that iframes were not reflowed in their parent DOM when the child page navigated. This is fixed by simply having the constellation notify the appropriate script thread when navigation occurs. The second bug was that the compositor was unable to adjust the pipeline for existing iframe layers, only new ones. This patch adds logic to do that. The third bug was that we have ad-hoc reflow calls throughout script/, and we didn't trigger any reflow from the code that dispatches the `load` event for the iframe so the test for the first two issues would always time out. The second commit adds another reflow call to do that, and also bites the bullet and adds a catch-all reflow (which does nothing if there's no dirty nodes in the document) at the return to the event loop. Closes #8081. Extension of #9285.  [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9421)


        compositing: Fix a couple of bugs that prevented iframes from painting

after navigation. The first bug was that iframes were not reflowed in their parent DOM when the child page navigated. This is fixed by simply having the constellation notify the appropriate script thread when navigation occurs. The second bug was that the compositor was unable to adjust the pipeline for existing iframe layers, only new ones. This patch adds logic to do that. Closes servo#8081.


        Auto merge of #9421 - jdm:iframe-painting-after-navigation-redux, r=jdm

compositing: Fix a couple of bugs that prevented iframes from painting after navigation. The first bug was that iframes were not reflowed in their parent DOM when the child page navigated. This is fixed by simply having the constellation notify the appropriate script thread when navigation occurs. The second bug was that the compositor was unable to adjust the pipeline for existing iframe layers, only new ones. This patch adds logic to do that. The third bug was that we have ad-hoc reflow calls throughout script/, and we didn't trigger any reflow from the code that dispatches the `load` event for the iframe so the test for the first two issues would always time out. The second commit adds another reflow call to do that, and also bites the bullet and adds a catch-all reflow (which does nothing if there's no dirty nodes in the document) at the return to the event loop. Closes #8081. Extension of #9285.  [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9421)

paulrouget mentioned this issue Oct 19, 2015

Servo + Browser.html: webplatform bugs browserhtml/browserhtml#562

Closed

62 of 92 tasks complete

jdm added the A-gfx/compositing label Oct 19, 2015

paulrouget mentioned this issue Nov 3, 2015

iframe content does not resize when iframe element is resized #8301

Closed

paulrouget mentioned this issue Nov 16, 2015

Setting iframe src right after appending it to the DOM doesn't work #7826

Closed

pcwalton added a commit to pcwalton/servo that referenced this issue Nov 24, 2015

When an iframe loads a new page, dirty and reflow it so that the layout

e5f5d90

fragment will pick up the new subpage ID. This is necessary to make its new contents show up! Closes servo#8081.

pcwalton mentioned this issue Nov 24, 2015

When an iframe loads a new page, dirty and reflow it so that the layout fragment will pick up the new subpage ID. #8662

Closed

pcwalton added a commit to pcwalton/servo that referenced this issue Nov 24, 2015

When an iframe loads a new page, dirty and reflow it so that the layout

3cafde1

fragment will pick up the new subpage ID. This is necessary to make its new contents show up! Closes servo#8081.

pcwalton mentioned this issue Jan 13, 2016

compositing: Fix a couple of bugs that prevented iframes from painting after navigation. #9285

Closed

paulrouget added the A-browserhtml/P1 label Jan 21, 2016

jdm mentioned this issue Jan 25, 2016

compositing: Fix a couple of bugs that prevented iframes from painting after navigation. #9421

Merged

bors-servo closed this in #9421 Jan 28, 2016

paulrouget mentioned this issue Mar 15, 2016

iframe.goBack() doesn't paint the previous pipeline #9919

Closed

servo / servo

iframe not painted anymore after navigation (regression c72d0c2) #8081

iframe not painted anymore after navigation (regression c72d0c2) #8081

paulrouget commented Oct 19, 2015

paulrouget commented Oct 19, 2015

glennw commented Oct 19, 2015

paulrouget commented Oct 20, 2015

glennw commented Oct 20, 2015

glennw commented Oct 21, 2015

metajack commented Nov 21, 2015

glennw commented Nov 22, 2015

servo / servo

Join GitHub today

iframe not painted anymore after navigation (regression c72d0c2) #8081

iframe not painted anymore after navigation (regression c72d0c2) #8081

Comments

paulrouget commented Oct 19, 2015

paulrouget commented Oct 19, 2015

glennw commented Oct 19, 2015

paulrouget commented Oct 20, 2015

glennw commented Oct 20, 2015

glennw commented Oct 21, 2015

metajack commented Nov 21, 2015

glennw commented Nov 22, 2015