Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement <table> 'rows' attribute #8084

Closed
frewsxcv opened this issue Oct 19, 2015 · 9 comments
Closed

Implement <table> 'rows' attribute #8084

frewsxcv opened this issue Oct 19, 2015 · 9 comments
Assignees
@KiChjang
Labels
A-content/dom C-assigned

Comments

@frewsxcv
Copy link
Member

@frewsxcv frewsxcv commented Oct 19, 2015

https://html.spec.whatwg.org/multipage/tables.html#dom-table-rows

This requires HTMLCollection to be updated to support more flexible custom iterators than just a simple filter

I started refactoring HTMLCollection and implementing <table> rows in this branch, but I'm going to hold off on contributing more to it for the time being incase anyone thinks of a better system. If anyone wants to give this a shot, feel free to steal my existing work
@frewsxcv
Copy link
Member Author

@frewsxcv frewsxcv commented Oct 19, 2015

/cc @asajeffrey @nox
@frewsxcv frewsxcv mentioned this issue Jan 12, 2016
Closed
@KiChjang KiChjang mentioned this issue Jan 12, 2016
Closed
@KiChjang KiChjang changed the title Implement <table> 'rows' method Implement <table> 'rows' attribute Jan 12, 2016
@KiChjang
Copy link
Member

@KiChjang KiChjang commented Jan 12, 2016

Blocks #9269.
@MonsieurLanza
Copy link
Contributor

@MonsieurLanza MonsieurLanza commented Jan 26, 2016

I'd like to take this.
But it may take some time, as I can only spend about 1-2h/day on servo, atm.
@nox
Copy link
Member

@nox nox commented Jan 26, 2016

@MonsieurLanza Go for it!
@nox nox added the C-assigned label Jan 26, 2016
MonsieurLanza added a commit to MonsieurLanza/servo that referenced this issue Feb 8, 2016
@MonsieurLanza
[WIP] Implement table rows attribute (servo#8084)
6ac39d4
@KiChjang
Copy link
Member

@KiChjang KiChjang commented Feb 20, 2016

@MonsieurLanza Are you still working on this? Just checking, because currently Servo doesn't render some Wikipedia pages well.
@MonsieurLanza
Copy link
Contributor

@MonsieurLanza MonsieurLanza commented Feb 20, 2016

Yes, but i won't have time to get back on it until monday.

Damien BRUN

Le 20 févr. 2016 à 05:17, Keith Yeung notifications@github.com a écrit :

@MonsieurLanza Are you still working on this?

—
Reply to this email directly or view it on GitHub.
@KiChjang
Copy link
Member

@KiChjang KiChjang commented Mar 16, 2016

@MonsieurLanza Still working?
@MonsieurLanza
Copy link
Contributor

@MonsieurLanza MonsieurLanza commented Mar 17, 2016

I m'm sorry I cannot free enough time to work efficiently on servo ATM (about 1h/week). So geek free to re-assign this, if you cannot wait.

Damien BRUN

Le 20 févr. 2016 à 05:17, Keith Yeung notifications@github.com a écrit :

@MonsieurLanza Are you still working on this?

—
Reply to this email directly or view it on GitHub.
@KiChjang
Copy link
Member

@KiChjang KiChjang commented Mar 17, 2016

No worries! If you have time to work on Servo again, ferl free to drop me a message and I'll look for an easy issue for you :)
@KiChjang KiChjang self-assigned this Mar 17, 2016
@KiChjang KiChjang mentioned this issue Mar 19, 2016
Merged
bors-servo added a commit that referenced this issue Mar 19, 2016
@bors-servo
Auto merge of #10086 - KiChjang:table-rows, r=<try>
Loading status checks…
6b8a8ea 
Implement HTMLTableElement#rows

Fixes #8084.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10086)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue Apr 7, 2016
@bors-servo
Auto merge of #10086 - KiChjang:table-rows, r=<try>
Loading status checks…
0de1474 
Implement HTMLTableElement#rows

Fixes #8084.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10086)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue Apr 9, 2016
@bors-servo
Auto merge of #10086 - KiChjang:table-rows, r=Manishearth
Loading status checks…
d11ed88 
Implement HTMLTableElement#rows

Fixes #8084.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10086)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue Apr 9, 2016
@bors-servo
Auto merge of #10086 - KiChjang:table-rows, r=Manishearth
Loading status checks…
32e53b8 
Implement HTMLTableElement#rows

Fixes #8084.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10086)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@KiChjang KiChjang

Labels
A-content/dom C-assigned
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
@nox @frewsxcv @KiChjang @MonsieurLanza
You can’t perform that action at this time.