Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Text cursor appears in wrong position for password inputs #8107

Closed
jdm opened this issue Oct 21, 2015 · 2 comments
Closed

Text cursor appears in wrong position for password inputs #8107

jdm opened this issue Oct 21, 2015 · 2 comments
Labels
A-content/dom A-layout/inline C-assigned

Comments

@jdm
Copy link
Member

@jdm jdm commented Oct 21, 2015

Perhaps it's something about multibyte characters? It usually falls behind the actual character display and doesn't appear to catch up.
@fiji-flo
Copy link
Contributor

@fiji-flo fiji-flo commented Oct 29, 2015

I will take a look. It's similar to my last issue.
@jdm
Copy link
Member Author

@jdm jdm commented Oct 29, 2015

Please do :)
@jdm jdm added the C-assigned label Oct 29, 2015
fiji-flo added a commit to fiji-flo/servo that referenced this issue Oct 30, 2015
@fiji-flo
add get_raw_layout_value (HTMLInputElementHelpers)
5af44a4 
This resolves servo#8107
Previously the index of the insetion point for a password input was
calculated using the scrambled string based on the edit point in the
raw string. That could lead to a wrong position of the caret. This
commit changes this behavior to calculate the insertion point using
the raw string.
@fiji-flo fiji-flo mentioned this issue Oct 30, 2015
Merged
fiji-flo added a commit to fiji-flo/servo that referenced this issue Nov 3, 2015
@fiji-flo
add get_insertion_point_index_for_layout
c26b80c 
This resolves servo#8107
Previously the index of the insetion point for a password input was
calculated using the scrambled string based on the edit point in the
raw string. That could lead to a wrong position of the caret. This
commit changes this behavior to calculate the insertion point using
the raw string.
This is done in
`HTMLInputElementHelpers::get_insertion_point_index_for_layout`
and relies on a 1:1 mapping of the chars in the raw input to the
scrambled chars (currently bullets) in the password input.
bors-servo added a commit that referenced this issue Nov 4, 2015
@bors-servo
Auto merge of #8265 - fiji-flo:password_caret, r=eefriedman
Loading status checks…
e91169c 
add get_raw_layout_value (HTMLInputElementHelpers)

This resolves #8107
Previously the index of the insetion point for a password input was
calculated using the scrambled string based on the edit point in the
raw string. That could lead to a wrong position of the caret. This
commit changes this behavior to calculate the insertion point using
the raw string.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8265)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-content/dom A-layout/inline C-assigned
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

add get_raw_layout_value (HTMLInputElementHelpers)
2 participants
@jdm @fiji-flo
You can’t perform that action at this time.