Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Node::remove_child not dirtying the parent #8135

Closed
asajeffrey opened this issue Oct 21, 2015 · 1 comment
Closed

Node::remove_child not dirtying the parent #8135

asajeffrey opened this issue Oct 21, 2015 · 1 comment
Labels
A-content/dom C-assigned

Comments

@asajeffrey
Copy link
Member

@asajeffrey asajeffrey commented Oct 21, 2015

In https://github.com/servo/servo/blob/master/components/script/dom/node.rs, we have:

fn remove_child(&self, child: &Node) {
    ...
    document.content_and_heritage_changed(child, NodeDamage::OtherNodeDamage);

}

so the child is being dirtied, but the parent isn't.
@asajeffrey asajeffrey mentioned this issue Oct 21, 2015
Closed
bors-servo added a commit that referenced this issue Nov 2, 2015
@bors-servo
Auto merge of #8139 - asajeffrey:remove_child_dirty_parent, r=pcwalton
23a0f6c 
Dirty parent when removing a child node.

In Node::remove_child, dirty both the child and the parent. Fixes #8135

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8139)
<!-- Reviewable:end -->
@jdm
Copy link
Member

@jdm jdm commented Nov 28, 2015

Fixed in #8315.
@jdm jdm closed this Nov 28, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-content/dom C-assigned
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
@mbrubeck @jdm @asajeffrey
You can’t perform that action at this time.