Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement document.createEvent("TouchEvent") #8160

Closed
mbrubeck opened this issue Oct 22, 2015 · 2 comments
Closed

Implement document.createEvent("TouchEvent") #8160

mbrubeck opened this issue Oct 22, 2015 · 2 comments
Labels
A-content/dom C-assigned E-easy I-enhancement

Comments

@mbrubeck
Copy link
Contributor

@mbrubeck mbrubeck commented Oct 22, 2015

This is a follow-up to issue #7204.

In the Document::CreateEvent method, add a case for "touchevent" that creates and returns a new TouchEvent.

The TouchEvent constructor takes three TouchList arguments. You can create an empty TouchList by calling TouchList::new with an empty array, then pass this TouchList to the TouchEvent constructor.

After this change, the following tests should pass. You can git rm the metadata files marking them as failing: Document-createEvent.html.ini and EventTarget-dispatchEvent.html.ini. Then run these commands to verify that both tests pass:

./mach test tests/wpt/web-platform-tests/dom/nodes/Document-createEvent.html
./mach test tests/wpt/web-platform-tests/dom/events/EventTarget-dispatchEvent.html
@mbrubeck mbrubeck mentioned this issue Oct 22, 2015
Merged
@ax3lst
Copy link
Contributor

@ax3lst ax3lst commented Oct 23, 2015

I can do this one
@ax3lst ax3lst mentioned this issue Oct 23, 2015
Merged
@jdm jdm added the C-assigned label Oct 23, 2015
bors-servo added a commit that referenced this issue Oct 28, 2015
@bors-servo
Auto merge of #8169 - ax3lst:master, r=eefriedman
Loading status checks…
7c9f464 
Implement document.createEvent(TouchEvent)

This solves #8160

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8169)
<!-- Reviewable:end -->
@wafflespeanut
Copy link
Member

@wafflespeanut wafflespeanut commented Nov 18, 2015

I guess #8169 closes this?
@Ms2ger Ms2ger closed this Nov 18, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-content/dom C-assigned E-easy I-enhancement
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants
@mbrubeck @jdm @Ms2ger @ax3lst @wafflespeanut
You can’t perform that action at this time.