Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix document.title setter for SVG documents to match spec changes #8164

Closed
eefriedman opened this issue Oct 22, 2015 · 0 comments
Closed

Fix document.title setter for SVG documents to match spec changes #8164

eefriedman opened this issue Oct 22, 2015 · 0 comments
Labels

Comments

@eefriedman
Copy link
Contributor

@eefriedman eefriedman commented Oct 22, 2015

See whatwg/html@f7ff53e . The relevant code in Servo is

let elem = root.upcast::<Node>()
.

Should be easy to fix... the only potentially tricky bit is that Servo can't parse SVG at the moment, so testing it involves synthesizing an SVG document using DOM calls. Nevermind, a test already exists (or at least it will next time we sync with upstream web-platform-tests),

@jdm jdm added the A-content/dom label Oct 22, 2015
bors-servo added a commit that referenced this issue Nov 7, 2015
Prepend, rather than append, SVG title elements.

Fixes #8164

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8296)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue Nov 7, 2015
Prepend, rather than append, SVG title elements.

Fixes #8164

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8296)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue Nov 7, 2015
Prepend, rather than append, SVG title elements.

Fixes #8164

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8296)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.