-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Subpixel positioning fails since ac5525a #8166
Comments
/cc @mrobinson |
Using |
I don't know how to get the pixel density in |
I think one issue here is that the layer boundaries are rounded instead of expanded to pixel boundaries. I have a fix for this which depends on servo/app_units#3 (though I don't have a readily accessible hidpi screen to test it on). |
@mrobinson Depending on what you're testing, you may be able to use --device-pixel-ratio=2 even on a non-hidpi monitor to test with. |
Before passing these layers to the paint task, expand them to pixel boundaries. This ensures that subpixel edges of the layer will not be clipped away and helps prevent rounding issues with layer contents. Fixes servo#8166.
Before passing these layers to the paint task, expand them to pixel boundaries. This ensures that subpixel edges of the layer will not be clipped away and helps prevent rounding issues with layer contents. Fixes servo#8166.
Expand DisplayList layer bounds to whole pixels Before passing these layers to the paint task, expand them to pixel boundaries. This ensures that subpixel edges of the layer will not be clipped away and helps prevent rounding issues with layer contents. Fixes #8166. <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8244) <!-- Reviewable:end -->
When an iframe is present in the document,
top:0.5px
is drawn at1px
.It's started with ac5525a.
The text was updated successfully, but these errors were encountered: