Intermittent failure in /_mozilla/css/last_of_type_pseudo_a.html #8191

jdm · 2015-10-25T16:07:15Z

Looks like a layout issue.

nox · 2016-02-19T13:46:28Z

With this in last_of_type_pseudo_a.html:

    <div id="d1">
      <p> </p>
      <div> </div>
      <div> </div>
      <p> </p>
      <address> </address>
      <p> </p>
      <div> </div>
      <p> </p>
      <p> </p>
      <address> </address>
<!--       <address class="ok"> </address>
      <p> </p>
      <div class="ok"> </div>
      <p> </p>
      <p class="ok"> </p> -->
    </div>

We get:

Seems like layout is done when the document isn't complete and these nodes aren't styled again when the rest is finally parsed and handled.

nox · 2016-02-19T13:53:16Z

<!DOCTYPE html>
<html>
  <head>
    <link rel='match' href='last_of_type_pseudo_b.html'>
    <title>:last-of-type test</title>
    <style type="text/css">
      html { background: red; }
      /* Should match according to Selectors Level 4 (changed from Level 3) */
      html:last-of-type { background: white; }

      div > p,
      div > div,
      div > address {
          float: left;
          width: 20px;
          height: 20px;
          margin: 0px;
          margin-right: 10px;
          padding: 0px;
      }
      div > p {
          background: white;
      }
      div > div,
      div > address {
          background: black;
      }
      body > div { clear: both; margin-bottom: 10px; }

      #d1 > .ok { background: red; }
      #d1 > *:last-of-type { background: green }

    </style>
    <script>
      setTimeout(function() {
        var d1 = document.getElementById("d1");
        var address = document.createElement("address");
        address.classList.add("ok");
        d1.appendChild(address);
        console.log("ok");
      }, 1000);
    </script>
  </head>
  <body>
    <div id="d1">
      <p> </p>
      <div> </div>
      <div> </div>
      <p> </p>
      <address> </address>
      <p> </p>
      <div> </div>
      <p> </p>
      <p> </p>
      <address> </address>
<!--       <address class="ok"> </address>
      <p> </p>
      <div class="ok"> </div>
      <p> </p>
      <p class="ok"> </p> -->
    </div>
  </body>
</html>

jdm · 2016-02-19T15:47:20Z

That last testcase works with -i (ie. incremental reflow disabled).

KiChjang · 2016-02-22T12:39:54Z

Disabled in #9716


        Mark elements whose children are affected by "slow" selectors

This required by the fix for servo/servo#8191.


        Dirty elements whose selectors are affected by sibling changes

This fixes incremental layout of nodes that match pseudo-class selectors such as :first-child, :nth-child, :last-child, :first-of-type, etc. Fixes servo#8191 and other intermittent layout bugs. This code is based on the following flags from Gecko: https://hg.mozilla.org/mozilla-central/file/e1cf617a1f28/dom/base/nsINode.h#l134


        Dirty elements whose selectors are affected by sibling changes

This fixes incremental layout of nodes that match pseudo-class selectors such as :first-child, :nth-child, :last-child, :first-of-type, etc. Fixes servo#8191 and servo#9063, and other intermittent layout bugs. This code is based on the following flags from Gecko: https://hg.mozilla.org/mozilla-central/file/e1cf617a1f28/dom/base/nsINode.h#l134


        Mark elements whose children are affected by "slow" selectors

This required by the fix for servo/servo#8191.


        Auto merge of #71 - mbrubeck:slow_selector, r=SimonSapin

@SimonSapin

Mark elements whose children are affected by "slow" selectors This required by the fix for servo/servo#8191. r? @SimonSapin  [<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/rust-selectors/71)


        Dirty elements whose selectors are affected by sibling changes

This fixes incremental layout of nodes that match pseudo-class selectors such as :first-child, :nth-child, :last-child, :first-of-type, etc. Fixes servo#8191 and servo#9063, and other intermittent layout bugs. This code is based on the following flags from Gecko: https://hg.mozilla.org/mozilla-central/file/e1cf617a1f28/dom/base/nsINode.h#l134


        Dirty elements whose selectors are affected by sibling changes

This fixes incremental layout of nodes that match pseudo-class selectors such as :first-child, :nth-child, :last-child, :first-of-type, etc. * Fixes servo#8191 * Fixes servo#9063 * Fixes servo#9303 * Fixes servo#9448 This code is based on the following flags from Gecko: https://hg.mozilla.org/mozilla-central/file/e1cf617a1f28/dom/base/nsINode.h#l134


        Dirty elements whose selectors are affected by sibling changes

This fixes incremental layout of nodes that match pseudo-class selectors such as :first-child, :nth-child, :last-child, :first-of-type, etc. * Fixes servo#8191 * Fixes servo#9063 * Fixes servo#9303 * Fixes servo#9448 This code is based on the following flags from Gecko: https://hg.mozilla.org/mozilla-central/file/e1cf617a1f28/dom/base/nsINode.h#l134


        Dirty elements whose selectors are affected by sibling changes

This fixes incremental layout of nodes that match pseudo-class selectors such as :first-child, :nth-child, :last-child, :first-of-type, etc. * Fixes servo#8191 * Fixes servo#9063 * Fixes servo#9303 * Fixes servo#9448 This code is based on the following flags from Gecko: https://hg.mozilla.org/mozilla-central/file/e1cf617a1f28/dom/base/nsINode.h#l134


        Dirty elements whose selectors are affected by sibling changes

This fixes incremental layout of nodes that match pseudo-class selectors such as :first-child, :nth-child, :last-child, :first-of-type, etc. * Fixes servo#8191 * Fixes servo#9063 * Fixes servo#9303 * Fixes servo#9448 This code is based on the following flags from Gecko: https://hg.mozilla.org/mozilla-central/file/e1cf617a1f28/dom/base/nsINode.h#l134


        Auto merge of #9722 - mbrubeck:slow-selector, r=nox

@SimonSapin

Dirty elements whose selectors are affected by sibling changes This fixes incremental layout of nodes that match pseudo-class selectors such as :first-child, :nth-child, :last-child, :first-of-type, etc. Fixes #8191 and other intermittent layout bugs. This code is based on the following flags from Gecko: https://hg.mozilla.org/mozilla-central/file/e1cf617a1f28/dom/base/nsINode.h#l134 Depends on servo/rust-selectors#71. r? @SimonSapin There are a couple of TODO items in this commit, but I'd appreciate feedback on the general approach before I finish it up. (Also, if someone who knows more than I do could give some advice about atomic orderings...)  [<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9722)

jdm added A-layout/uncategorized I-intermittent labels Oct 25, 2015

jdm mentioned this issue Oct 25, 2015

Correct the match urls for the white-space tests. #8185

Merged

dzbarsky mentioned this issue Oct 30, 2015

Allow more valid use of calc expressions #7400

Merged

This was referenced Nov 3, 2015

Removced unncessary call to dirty() in Document::node_and_heritage_ch… #8087

Merged

Print process output for TIMEOUT status in WPT UI #8323

Merged

jdm mentioned this issue Nov 4, 2015

Investigations for #7787 #8314

Merged

larsbergstrom mentioned this issue Dec 23, 2015

Update layers. #9058

Merged

KiChjang mentioned this issue Jan 29, 2016

Update to servo-glutin 0.4.8 #9454

Merged

larsbergstrom mentioned this issue Jan 29, 2016

Fix AArch64 target triplets #9447

Merged

This was referenced Jan 30, 2016

Add mach test-webidl command #9459

Merged

Remove old features 'clone_from_slice' and 'convert' #9512

Merged

This was referenced Feb 5, 2016

fix #8461 #9471

Merged

Update immeta dependency to resolve ImageCacheThread panic #9542

Merged

jdm mentioned this issue Feb 11, 2016

Add a "mach test-wpt --chaos" mode for reproducing intermittent failures using rr #9607

Merged

KiChjang mentioned this issue Feb 12, 2016

Calculate correct mp4 header length. #9618

Merged

jdm mentioned this issue Feb 12, 2016

Download extra stdlib only when required: #9557 #9611

Merged

emilio mentioned this issue Feb 13, 2016

style: Make the whole style crate independent of the implementation #9567

Merged

nox mentioned this issue Feb 15, 2016

#9640 Refactor: Move util::str::is_token to script::dom::bindings::str #9642

Merged

This was referenced Feb 15, 2016

Cache XHR JSON responses #9621

Merged

Ensure when calculating font metrics that the total line height matches requested line height. #9668

Merged

nox mentioned this issue Feb 19, 2016

All interface objects now share the same hasInstance #9633

Merged

KiChjang changed the title ~~Intermittent failure in _mozilla/css/last_of_type_pseudo_a.html~~ Intermittent failure in /_mozilla/css/last_of_type_pseudo_a.html Feb 19, 2016

KiChjang mentioned this issue Feb 19, 2016

Avoid some spurious string copies in XHR. #9700

Merged

mbrubeck self-assigned this Feb 19, 2016

mbrubeck mentioned this issue Feb 19, 2016

Intermittent failure of /_mozilla/css/nth_last_child_pseudo_a.html #9699

Closed

KiChjang mentioned this issue Feb 20, 2016

Improvements to Documents' browsing contexts. #9714

Merged

mbrubeck added a commit to mbrubeck/rust-selectors that referenced this issue Feb 22, 2016

Mark elements whose children are affected by "slow" selectors

9c76d08

This required by the fix for servo/servo#8191.

mbrubeck mentioned this issue Feb 22, 2016

Mark elements whose children are affected by "slow" selectors servo/rust-selectors#71

Merged

mbrubeck mentioned this issue Feb 22, 2016

Dirty elements whose selectors are affected by sibling changes #9722

Merged

mbrubeck added a commit to mbrubeck/rust-selectors that referenced this issue Feb 23, 2016

Mark elements whose children are affected by "slow" selectors

2b53d2e

This required by the fix for servo/servo#8191.

bors-servo closed this in #9722 Feb 24, 2016

servo / servo

Intermittent failure in /_mozilla/css/last_of_type_pseudo_a.html #8191

Intermittent failure in /_mozilla/css/last_of_type_pseudo_a.html #8191

jdm commented Oct 25, 2015

nox commented Feb 19, 2016

nox commented Feb 19, 2016

jdm commented Feb 19, 2016

KiChjang commented Feb 22, 2016

servo / servo

Join GitHub today

Intermittent failure in /_mozilla/css/last_of_type_pseudo_a.html #8191

Intermittent failure in /_mozilla/css/last_of_type_pseudo_a.html #8191

Comments

jdm commented Oct 25, 2015

nox commented Feb 19, 2016

nox commented Feb 19, 2016

jdm commented Feb 19, 2016

KiChjang commented Feb 22, 2016