servo / servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Is Window::force_reflow racey? #8209

Closed

Ms2ger opened this issue Oct 26, 2015 · 1 comment

Contributor

Ms2ger commented Oct 26, 2015

From Window::force_reflow:

        // FIXME(cgaebel): this is racey. What if the compositor triggers a
        // reflow between the "join complete" message and returning from this
        // function?

This was added in dafd0b6 (#3164).

@cgaebel, what's up here?

Contributor

cgaebel commented Nov 3, 2015

Uhhh I don't remember, sorry! Feel free to remove the comment.

bors-servo added a commit that referenced this issue


        Auto merge of #8332 - Ms2ger:8209-comment, r=frewsxcv

1dc144d

Remove obsolete comment (fixes #8209).

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8332)
<!-- Reviewable:end -->

Ms2ger closed this in

208140d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

You can’t perform that action at this time.