Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove JS::root. #8251

Closed
Ms2ger opened this issue Oct 29, 2015 · 2 comments
Closed

Remove JS::root. #8251

Ms2ger opened this issue Oct 29, 2015 · 2 comments
Labels
A-content/bindings C-assigned E-easy I-refactor

Comments

@Ms2ger
Copy link
Contributor

@Ms2ger Ms2ger commented Oct 29, 2015

The method is defined in components/script/dom/bindings/js.rs.

It should be possible to remove most calls altogether, and use the JS<T> where the Root<T> return value is currently used. When that isn't possible, Root::from_ref(&*js) should work.
@nxnfufunezn
Copy link
Contributor

@nxnfufunezn nxnfufunezn commented Oct 29, 2015

I will take this one
@jdm jdm added the C-assigned label Oct 29, 2015
@jdm
Copy link
Member

@jdm jdm commented Oct 29, 2015

Please do!
nxnfufunezn added a commit to nxnfufunezn/servo that referenced this issue Oct 30, 2015
@nxnfufunezn
Removed JS::root servo#8251
46585fb 
Fixes servo#8251
@nxnfufunezn nxnfufunezn mentioned this issue Oct 30, 2015
Merged
Ms2ger added a commit to Ms2ger/servo that referenced this issue Oct 30, 2015
@Ms2ger
fixup! Removed JS::root servo#8251 Fixes servo#8251
2151677
nxnfufunezn added a commit to nxnfufunezn/servo that referenced this issue Oct 31, 2015
@nxnfufunezn
Removed JS::root Fixes servo#8251
d0aaeb9
nxnfufunezn added a commit to nxnfufunezn/servo that referenced this issue Oct 31, 2015
@nxnfufunezn
Removed JS::root Fixes servo#8251
f7bd19b
nxnfufunezn added a commit to nxnfufunezn/servo that referenced this issue Oct 31, 2015
@nxnfufunezn
Removed JS::root Fixes servo#8251
d8ef380
bors-servo added a commit that referenced this issue Oct 31, 2015
@bors-servo
Auto merge of #8262 - nxnfufunezn:Remove_JS_root, r=Ms2ger
Loading status checks…
37c03c7 
Removed JS::root #8251

Fixes #8251 

r? @Ms2ger

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8262)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-content/bindings C-assigned E-easy I-refactor
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
@jdm @Ms2ger @nxnfufunezn
You can’t perform that action at this time.