Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd Windows support for the new WPT test runner UI #8313
Closed
Labels
Comments
|
I'm looking into this because of #17392. Per an IRC discussion with @retep998, It appears that ANSI can be made to work in Windows 10 well enough for what we're doing. I've hard-coded the line width. Python terminal support for earlier versions of Windows is an epic train wreck. I don't think there's a cross-platform Python package for it, but haven't researched it heavily. |
Merged
bors-servo
added a commit
that referenced
this issue
Jun 21, 2017
Windows can run WPT <!-- Please describe your changes on the following line: --> This PR contains fixes that address the specific errors in #17392: WTP workarounds for Windows terminals (see #8313), modifications to `mach test --all` that allow `test_tidy` to be called properly, and modifications to the test harness for WPT that allow it to run when OpenSSL isn't found. How to handle OpenSSL on Windows is probably a separate issue because it doesn't have a straightforward answer: we either need to provide specific instructions to users or bundle it in binary form ourselves. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #17392 (github issue number if applicable). <!-- Either: --> - [x] These changes do not require tests because they fix test running. <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17419) <!-- Reviewable:end -->
bors-servo
added a commit
that referenced
this issue
Jun 22, 2017
Windows can run WPT <!-- Please describe your changes on the following line: --> This PR contains fixes that address the specific errors in #17392: WTP workarounds for Windows terminals (see #8313), modifications to `mach test --all` that allow `test_tidy` to be called properly, and modifications to the test harness for WPT that allow it to run when OpenSSL isn't found. How to handle OpenSSL on Windows is probably a separate issue because it doesn't have a straightforward answer: we either need to provide specific instructions to users or bundle it in binary form ourselves. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #17392 (github issue number if applicable). <!-- Either: --> - [x] These changes do not require tests because they fix test running. <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17419) <!-- Reviewable:end -->
bors-servo
added a commit
that referenced
this issue
Jun 22, 2017
Windows can run WPT <!-- Please describe your changes on the following line: --> This PR contains fixes that address the specific errors in #17392: WTP workarounds for Windows terminals (see #8313), modifications to `mach test --all` that allow `test_tidy` to be called properly, and modifications to the test harness for WPT that allow it to run when OpenSSL isn't found. How to handle OpenSSL on Windows is probably a separate issue because it doesn't have a straightforward answer: we either need to provide specific instructions to users or bundle it in binary form ourselves. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #17392 (github issue number if applicable). <!-- Either: --> - [x] These changes do not require tests because they fix test running. <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17419) <!-- Reviewable:end -->
|
@camlorn Just looking through some of my old bugs and wanted to check in with you about this: Can we close this bug now since it seems that your changes allow the WPT UI to run on Windows? If not, what's a good description for this bug to encapsulate the current work remaining to do? |
|
@mrobinson It's been too long for me to remember specifics, but I'd suggest closing this and waiting for someone to open another ticket if there's still a problem. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
It currently uses escape codes that probably do not work in Windows terminals.