-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support mozbrowsericonchange event (Browser API) #8347
Comments
I'm giving it a try: paulrouget@97cee8b At the moment, we are limited by the @glennw what would you recommend here? |
@jdm I'm trying to use
What's the right approach in this case? |
Don't do that. You shouldn't be handling a JSContext outside of the script crate/thread. |
The right approach is to make 'detail' a method of a trait that's defined in the script crate. |
moving
|
Creating a |
feedback? paulrouget@2f5fa1b Does this look like the right approach? Still need to do some clean-up, address the fixme, and write some tests |
It does! |
mozbrowsericonchange event (Browser API) fixes #8347 <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8449) <!-- Reviewable:end -->
mozbrowsericonchange event (Browser API) fixes #8347 <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8449) <!-- Reviewable:end -->
mozbrowsericonchange event (Browser API) fixes #8347 <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8449) <!-- Reviewable:end -->
No description provided.
The text was updated successfully, but these errors were encountered: