Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement HTMLScriptElement.src #845

Closed
jdm opened this issue Aug 31, 2013 · 10 comments
Closed

Implement HTMLScriptElement.src #845

jdm opened this issue Aug 31, 2013 · 10 comments

Comments

@jdm
Copy link
Member

@jdm jdm commented Aug 31, 2013

Needed for #841.

@jdm
Copy link
Member Author

@jdm jdm commented Oct 7, 2013

For the person (kangz) on IRC who was asking about writing tests - ignore src/test/html, and write tests in src/test/html/content instead.

@marcoscaceres
Copy link
Contributor

@marcoscaceres marcoscaceres commented Oct 8, 2013

Is there some kind of contributor guide for this project? It would be good to clarify the testing story there and put something slightly more concrete in place. I say this because I also was not sure what kind of test was expected with a PR.

@jdm
Copy link
Member Author

@jdm jdm commented Oct 8, 2013

@marcoscaceres There's https://github.com/mozilla/servo/wiki/Contributing. We could probably expand on it, too.

@marcoscaceres
Copy link
Contributor

@marcoscaceres marcoscaceres commented Oct 8, 2013

Filed a bug about contributing (happy to help with that) #1026

@ibnc
Copy link

@ibnc ibnc commented Oct 20, 2013

Just looking for some clarification on this bug... I'm assuming that a request needs to be made to the url provided, and then the javascript needs to be evaluated. Or is it just as simple as setting the src attribute in HTMLScriptElement?

@Ms2ger
Copy link
Contributor

@Ms2ger Ms2ger commented Oct 20, 2013

For #841, what's needed is that script.src returns the resolved* value of the src content attribute. The setter isn't required there. (Though the actual script loading trigger should be in whatever we do for AfterSetAttr, or something.)

[*] might not even need to be resolved, actually.

@ibnc
Copy link

@ibnc ibnc commented Oct 20, 2013

Okay I think I understand, but just to make sure HTMLScriptElement.src should return the value set in the src parameter of the script tag.

@tetsuharuohzeki
Copy link
Member

@tetsuharuohzeki tetsuharuohzeki commented Oct 23, 2013

We haven't implemented the setter yet. I think we should keep open this, or file the new issue about it.

@jdm
Copy link
Member Author

@jdm jdm commented Oct 23, 2013

We'll file a new one, because it's significantly more complicated than the getter, and we only need the getter for #841.

@tetsuharuohzeki
Copy link
Member

@tetsuharuohzeki tetsuharuohzeki commented Oct 23, 2013

OK. I filed #1113.

ChrisParis pushed a commit to ChrisParis/servo that referenced this issue Sep 7, 2014
Remove preload tests until review is complete.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

5 participants
You can’t perform that action at this time.