Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upImplement HTMLScriptElement.src #845
Comments
|
For the person ( |
|
Is there some kind of contributor guide for this project? It would be good to clarify the testing story there and put something slightly more concrete in place. I say this because I also was not sure what kind of test was expected with a PR. |
|
@marcoscaceres There's https://github.com/mozilla/servo/wiki/Contributing. We could probably expand on it, too. |
|
Filed a bug about contributing (happy to help with that) #1026 |
|
Just looking for some clarification on this bug... I'm assuming that a request needs to be made to the url provided, and then the javascript needs to be evaluated. Or is it just as simple as setting the src attribute in HTMLScriptElement? |
|
For #841, what's needed is that [*] might not even need to be resolved, actually. |
|
Okay I think I understand, but just to make sure HTMLScriptElement.src should return the value set in the src parameter of the script tag. |
|
We haven't implemented the setter yet. I think we should keep open this, or file the new issue about it. |
|
We'll file a new one, because it's significantly more complicated than the getter, and we only need the getter for #841. |
|
OK. I filed #1113. |
Remove preload tests until review is complete.
Needed for #841.