Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upDocument layout dirtiness flags, restyle hints, etc. #8450
Closed
Labels
Comments
|
Restyle hints are pretty well-documented (see the comments in restyle_hints.rs). The |dirty| flag is not well-documented, possibly because its semantics are somewhat ill-defined and need improvement. At the moment, |dirty| is basically a union indicating that at least one of the following is true:
There may be others (I'm figuring this out as I go along). All this code could certainly benefit from additional cleanup. |
|
I probably didn't help, by highjacking dirtiness for DOM versioning and cache invalidation of HTMLCollection objects. A tidy up would help. |
|
These are documented now, AFAICT. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
All this code seems amazingly complex and brittle. We should clearly document the exact constraints and invariants, and how we ensure they hold.
CC @pcwalton @bholley