Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop eagerly compiling raw uncompiled event handlers #8489

Closed
jdm opened this issue Nov 12, 2015 · 0 comments
Closed

Stop eagerly compiling raw uncompiled event handlers #8489

jdm opened this issue Nov 12, 2015 · 0 comments
Assignees
@jdm
Labels
A-content/dom

Comments

@jdm
Copy link
Member

@jdm jdm commented Nov 12, 2015

Stuff like <body onload="foo()"> is eagerly compiled right now, and the spec says it should not be until we get the value of the event handler (either through body.onload or using it for an event target chain).

I have patches that correct this.
@jdm jdm added the A-content/dom label Nov 12, 2015
@jdm jdm self-assigned this Nov 12, 2015
jdm added a commit to jdm/servo that referenced this issue Nov 12, 2015
@jdm
Compile raw inline event handlers lazily. Resolves servo#8489.
18d10e7
jdm added a commit to jdm/servo that referenced this issue Nov 13, 2015
@jdm
Compile raw inline event handlers lazily. Resolves servo#8489.
26eede2
Ms2ger added a commit to Ms2ger/servo that referenced this issue Nov 30, 2015
@jdm @Ms2ger
Compile raw inline event handlers lazily. Resolves servo#8489.
12c43c0
jdm added a commit to jdm/servo that referenced this issue Dec 31, 2015
@jdm
Compile raw inline event handlers lazily. Resolves servo#8489.
ade136b
jdm added a commit to jdm/servo that referenced this issue Jan 4, 2016
@jdm @Ms2ger
Compile raw inline event handlers lazily. Resolves servo#8489.
e8f6ae1
Ms2ger added a commit to jdm/servo that referenced this issue Feb 5, 2016
@jdm @Ms2ger
Compile raw inline event handlers lazily. Resolves servo#8489.
ce2435d
jdm added a commit to jdm/servo that referenced this issue Feb 5, 2016
@jdm
fixup! Compile raw inline event handlers lazily. Resolves servo#8489.
2943c60
jdm added a commit to jdm/servo that referenced this issue Feb 11, 2016
@jdm
Compile raw inline event handlers lazily. Resolves servo#8489.
65f82ce
bors-servo added a commit that referenced this issue Feb 11, 2016
@bors-servo
Auto merge of #8491 - jdm:lazycompile, r=Ms2ger
Loading status checks…
5942e9e 
Compile raw inline event handlers lazily. Resolves #8489.

Per https://html.spec.whatwg.org/multipage/webappapis.html#getting-the-current-value-of-the-event-handler and https://html.spec.whatwg.org/multipage/webappapis.html#event-handler-attributes:event-handlers-2 .

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8491)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jdm jdm

Labels
A-content/dom
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
@jdm
You can’t perform that action at this time.