Implement DOMMatrix. #8509

Ms2ger · 2015-11-13T14:03:30Z

Blocks #6097, #8822.

Spec: https://drafts.fxtf.org/geometry/#DOMMatrix
Code would be in new files (components/script/dom/dommatrix.rs, components/script/dom/webidls/DOMMatrix.webidl) and a mod dommatrix; in components/script/dom/mod.rs.
Test: ./tests/wpt/css-tests/geometry-1_dev/html/DOMMatrix-001.htm (metadata: ./tests/wpt/metadata-css/geometry-1_dev/html/DOMMatrix-001.htm.ini; see tests/wpt/README.md for more information).

ajnirp · 2015-11-14T17:13:59Z

can i work on this?

jdm · 2015-11-14T22:08:32Z

Yep!

frewsxcv · 2016-01-15T02:31:14Z

Still working on this @wenderen?

KiChjang · 2016-02-01T20:52:58Z

@wenderen Let us know if you want to pick this up again. In the meantime, I'm unassigning this issue.

peterjoel · 2016-02-14T23:01:08Z

I would like to pick this one up please.

frewsxcv · 2016-02-14T23:12:21Z

Go for it! Let us know if you run into any issues

peterjoel · 2016-02-14T23:15:57Z

@frewsxcv I'm sure I will!
For starters, are there existing matrix operations, used internally by servo, that can be bound to?

I'm looking at this PR for DOMQuads, and it looks like a good reference for the ~~amount and~~ type of work that needs to be done. Is that a fair assessment?

jdm · 2016-02-15T01:18:47Z

The euclid library has matrix implementations: http://doc.servo.org/servo/euclid/struct.Matrix2D.html and http://doc.servo.org/servo/euclid/struct.Matrix4.html . The DOMQuads PR looks like a valid reference.

peterjoel · 2016-02-21T00:41:23Z

@jdm Is it a problem that euclid matrices use f32, while the webidl generated traits use f64?

jdm · 2016-02-21T16:15:39Z

Probably! Maybe create a new one?

peterjoel · 2016-02-21T17:48:12Z

Perhaps it would be better to make generic versions of the euclid objects and then make the existing ones aliases for those?

jdm · 2016-02-21T18:29:17Z

Seems reasonable to me!

peterjoel · 2016-02-29T22:07:02Z

I get an error when implementing a method that uses a Float32Array or Float64Array: "Can't handle SpiderMonkey interface arguments yet". This is coming from here.

Is it something I can fix easily, or should I just skip these for now?

KiChjang · 2016-02-29T22:32:39Z

We currently don't support any sort of ArrayBuffers with our codegen. Tracking issue is #5014. Skip those for now.

peterjoel · 2016-03-03T20:40:53Z

I have a query about the existing test:
https://github.com/servo/servo/blob/master/tests/wpt/css-tests/geometry-1_dev/html/DOMMatrix-001.htm#L138

The test is failing because I don't throw a TypeError here. But this looks to be correct according to the spec. A 6 element sequence as the argument should represent a 2D array, and there is no mention of throwing errors based on the values themselves:
https://drafts.fxtf.org/geometry/#dom-dommatrixreadonly-dommatrixreadonly-numbersequence

Ms2ger · 2016-03-04T07:50:55Z

It seems to test that you can't construct a DOMMatrixReadOnly at all, which seems wrong. Feel free to ignore those tests.

stjepang · 2016-03-31T21:59:39Z

Any updates on this issue? :)
In case it got forgotten or abandoned, I'd be willing to implement it.

jdm · 2016-03-31T22:02:38Z

Nope, @peterjoel is actively working on it. There are just a bunch of moving pieces in other repositories which have ended up being necessary.

jdm · 2016-05-25T15:50:47Z

@peterjoel How's this progressing? Anything we can help with?

peterjoel · 2016-05-26T22:36:41Z

@jdm I've been busy with my job. But the feature is mostly done. Outstanding is just tests and the CSS-style initialisers. There is a 3-day weekend coming up this weekend, and I should get the PR in.


        Auto merge of #12202 - peterjoel:issue_8509, r=<try>

DOMMatrix and DOMMatrixReadOnly  ---  - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #8509.  - [ ] There are tests for these changes OR - [ ] These changes do not require tests because _____   --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12202)


        servo#8509 Review feedback. Replaced to_DOMMatrix with from_readonly


        servo#8509 Fixed panic due to double borrow of DOMRefCell


        servo#8509 Fixed panic due to double borrow of DOMRefCell


        servo#8509 Fixed panic due to double borrow of DOMRefCell


        servo#8509 Fixed fallible methods and removed return values on intern…

…al methods


        servo#8509 Fixed fallible methods and removed return values on intern…

…al methods


        servo#8509 Review feedback. Replaced to_DOMMatrix with from_readonly


        servo#8509 Fixed panic due to double borrow of DOMRefCell


        servo#8509 Fixed fallible methods and removed return values on intern…

…al methods


        servo#8509 Fixed error in dictionary fixup


        servo#8509 Fixed bug with dictionary fixups being misapplied.

Spec issue: https://www.w3.org/Bugs/Public/show_bug.cgi?id=29719


        servo#8509 Fixed fallible methods and removed return values on intern…

…al methods


        servo#8509 Fixed error in dictionary fixup


        servo#8509 Fixed bug with dictionary fixups being misapplied.

Spec issue: https://www.w3.org/Bugs/Public/show_bug.cgi?id=29719


        Auto merge of #12202 - peterjoel:issue_8509, r=<try>

DOMMatrix and DOMMatrixReadOnly  ---  - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #8509.  - [ ] There are tests for these changes OR - [ ] These changes do not require tests because _____   --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12202)


        Auto merge of #12202 - peterjoel:issue_8509, r=nox

DOMMatrix and DOMMatrixReadOnly  ---  - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #8509.  - [ ] There are tests for these changes OR - [ ] These changes do not require tests because _____   --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12202)


        Auto merge of #12202 - peterjoel:issue_8509, r=nox

DOMMatrix and DOMMatrixReadOnly  ---  - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #8509.  - [ ] There are tests for these changes OR - [ ] These changes do not require tests because _____   --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12202)


        Auto merge of #12202 - peterjoel:issue_8509, r=nox

DOMMatrix and DOMMatrixReadOnly  ---  - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #8509.  - [ ] There are tests for these changes OR - [ ] These changes do not require tests because _____   --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12202)

Ms2ger added A-content/dom E-easy I-enhancement labels Nov 13, 2015

ajnirp mentioned this issue Nov 14, 2015

replace TypeMismatchError with TypeError in domexception.rs #8528

Closed

Manishearth added the C-assigned label Nov 15, 2015

KiChjang removed the C-assigned label Feb 1, 2016

frewsxcv added the C-assigned label Feb 14, 2016

peterjoel mentioned this issue Feb 22, 2016

Create generic versions of Matrix and Point objects, parametrised by field type servo/euclid#125

Closed

jdm added the C-has open PR label Mar 31, 2016

peterjoel mentioned this issue May 30, 2016

Implement DOMMatrix (issue #8509) #11515

Closed

3 of 5 tasks complete

KiChjang added the C-has open PR label Jun 11, 2016

peterjoel mentioned this issue Jul 3, 2016

DOMMatrix and DOMMatrixReadOnly #12202

Merged

3 of 5 tasks complete

peterjoel added a commit to peterjoel/servo that referenced this issue Jul 4, 2016

servo#8509 Review feedback. Replaced to_DOMMatrix with from_readonly

004f1c4

peterjoel added a commit to peterjoel/servo that referenced this issue Jul 4, 2016

servo#8509 Fixed panic due to double borrow of DOMRefCell

71e04b6

peterjoel added a commit to peterjoel/servo that referenced this issue Jul 5, 2016

servo#8509 Fixed panic due to double borrow of DOMRefCell

d8dc2c6

peterjoel added a commit to peterjoel/servo that referenced this issue Jul 5, 2016

servo#8509 Fixed panic due to double borrow of DOMRefCell

df71a17

peterjoel added a commit to peterjoel/servo that referenced this issue Jul 6, 2016

servo#8509 Fixed fallible methods and removed return values on intern…

9757fc1

…al methods

peterjoel added a commit to peterjoel/servo that referenced this issue Jul 6, 2016

servo#8509 Fixed fallible methods and removed return values on intern…

fbac278

…al methods

peterjoel added a commit to peterjoel/servo that referenced this issue Jul 6, 2016

servo#8509 Review feedback. Replaced to_DOMMatrix with from_readonly

a71860f

peterjoel added a commit to peterjoel/servo that referenced this issue Jul 6, 2016

servo#8509 Fixed panic due to double borrow of DOMRefCell

9cc9a39

peterjoel added a commit to peterjoel/servo that referenced this issue Jul 6, 2016

servo#8509 Fixed fallible methods and removed return values on intern…

cdd50dc

…al methods

peterjoel added a commit to peterjoel/servo that referenced this issue Jul 7, 2016

servo#8509 Fixed error in dictionary fixup

81616c8

peterjoel added a commit to peterjoel/servo that referenced this issue Jul 7, 2016

servo#8509 Fixed bug with dictionary fixups being misapplied.

fdeb039

Spec issue: https://www.w3.org/Bugs/Public/show_bug.cgi?id=29719

peterjoel added a commit to peterjoel/servo that referenced this issue Jul 7, 2016

servo#8509 Fixed fallible methods and removed return values on intern…

56bcf2c

…al methods

peterjoel added a commit to peterjoel/servo that referenced this issue Jul 7, 2016

servo#8509 Fixed error in dictionary fixup

e4605b9

peterjoel added a commit to peterjoel/servo that referenced this issue Jul 7, 2016

servo#8509 Fixed bug with dictionary fixups being misapplied.

14cf6cb

Spec issue: https://www.w3.org/Bugs/Public/show_bug.cgi?id=29719

bors-servo closed this in #12202 Sep 16, 2016

servo / servo

Implement DOMMatrix. #8509

Implement DOMMatrix. #8509

Ms2ger commented Nov 13, 2015

ajnirp commented Nov 14, 2015

jdm commented Nov 14, 2015

frewsxcv commented Jan 15, 2016

KiChjang commented Feb 1, 2016

peterjoel commented Feb 14, 2016

frewsxcv commented Feb 14, 2016

peterjoel commented Feb 14, 2016

jdm commented Feb 15, 2016

peterjoel commented Feb 21, 2016

jdm commented Feb 21, 2016

peterjoel commented Feb 21, 2016

jdm commented Feb 21, 2016

peterjoel commented Feb 29, 2016

KiChjang commented Feb 29, 2016

peterjoel commented Mar 3, 2016

Ms2ger commented Mar 4, 2016

stjepang commented Mar 31, 2016

jdm commented Mar 31, 2016

jdm commented May 25, 2016

peterjoel commented May 26, 2016

servo / servo

Join GitHub today

Implement DOMMatrix. #8509

Implement DOMMatrix. #8509

Comments

Ms2ger commented Nov 13, 2015

ajnirp commented Nov 14, 2015

jdm commented Nov 14, 2015

frewsxcv commented Jan 15, 2016

KiChjang commented Feb 1, 2016

peterjoel commented Feb 14, 2016

frewsxcv commented Feb 14, 2016

peterjoel commented Feb 14, 2016

jdm commented Feb 15, 2016

peterjoel commented Feb 21, 2016

jdm commented Feb 21, 2016

peterjoel commented Feb 21, 2016

jdm commented Feb 21, 2016

peterjoel commented Feb 29, 2016

KiChjang commented Feb 29, 2016

peterjoel commented Mar 3, 2016

Ms2ger commented Mar 4, 2016

stjepang commented Mar 31, 2016

jdm commented Mar 31, 2016

jdm commented May 25, 2016

peterjoel commented May 26, 2016