Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update our implementation of DOMTokenList and DOMSettableTokenList #8511

Closed
nox opened this issue Nov 13, 2015 · 3 comments
Closed

Update our implementation of DOMTokenList and DOMSettableTokenList #8511

nox opened this issue Nov 13, 2015 · 3 comments
Labels
A-content/dom C-assigned

Comments

@nox
Copy link
Member

@nox nox commented Nov 13, 2015

The specification changed:

whatwg/dom#28
whatwg/dom#91
whatwg/dom#105
@nox nox added the A-content/dom label Nov 13, 2015
@nox
Copy link
Member Author

@nox nox commented Nov 13, 2015

whatwg/dom@63a0302
@Ms2ger
Copy link
Contributor

@Ms2ger Ms2ger commented Nov 13, 2015

This might involve writing or updating tests.
@frewsxcv
Copy link
Member

@frewsxcv frewsxcv commented Nov 13, 2015

Relevant: web-platform-tests/wpt#2323
ngsankha added a commit to ngsankha/servo that referenced this issue Nov 14, 2015
@ngsankha
Add DomTokenList.replace and tests. Fixes servo#8511
20a6557
@ngsankha ngsankha mentioned this issue Nov 14, 2015
Closed
@jdm jdm added the C-assigned label Nov 28, 2015
@nox nox mentioned this issue Dec 13, 2015
Merged
nox added a commit to nox/servo that referenced this issue Jan 17, 2016
@ngsankha @nox
Implement and test DOMTokenList.replace (fixes servo#8511)
b1f5276
nox added a commit to nox/servo that referenced this issue Feb 25, 2016
@ngsankha @nox
Implement and test DOMTokenList.replace (fixes servo#8511)
636c0fc
nox added a commit to nox/servo that referenced this issue Mar 22, 2016
@ngsankha @nox
Implement and test DOMTokenList.replace (fixes servo#8511)
d848645
bors-servo added a commit that referenced this issue Mar 25, 2016
@bors-servo
Auto merge of #9353 - nox:domtokenlist-replace, r=asajeffrey
Loading status checks…
59ba00e 
Implement and test DOMTokenList.replace (fixes #8511)

Thanks to @sankha93 for the original work in #8525.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9353)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-content/dom C-assigned
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
@jdm @Ms2ger @nox @frewsxcv
You can’t perform that action at this time.