Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

text input: draw caret even if there's no text #8543

Closed
paulrouget opened this issue Nov 16, 2015 · 5 comments
Closed

text input: draw caret even if there's no text #8543

paulrouget opened this issue Nov 16, 2015 · 5 comments
Labels
A-layout/uncategorized I-wrong

Comments

@paulrouget
Copy link
Contributor

@paulrouget paulrouget commented Nov 16, 2015

I think caret is only drawn if there's a text fragment.
@paulrouget paulrouget mentioned this issue Nov 16, 2015
Closed
62 of 92 tasks complete
@frewsxcv
Copy link
Member

@frewsxcv frewsxcv commented Dec 2, 2015

Just encountered this. Gif of the interaction:
@frewsxcv frewsxcv mentioned this issue Dec 2, 2015
Closed
@frewsxcv frewsxcv added the I-wrong label Dec 2, 2015
@Manishearth Manishearth mentioned this issue Dec 15, 2015
Merged
@Manishearth
Copy link
Member

@Manishearth Manishearth commented Dec 15, 2015

#7644

The caret doesn't show up if there's no text present, because we don't create text runs in that case. This should be a followup.
@pcwalton
Copy link
Contributor

@pcwalton pcwalton commented Dec 15, 2015

Maybe just create a dummy scanned text fragment?
@paulrouget
Copy link
Contributor Author

@paulrouget paulrouget commented Jan 5, 2016

Maybe just create a dummy scanned text fragment?

Where should this be done?
@paulrouget
Copy link
Contributor Author

@paulrouget paulrouget commented Feb 1, 2016

This works now.
@paulrouget paulrouget closed this Feb 1, 2016
@paulrouget paulrouget mentioned this issue Mar 15, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-layout/uncategorized I-wrong
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants
@jdm @pcwalton @paulrouget @frewsxcv @Manishearth
You can’t perform that action at this time.