Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split ScriptMsg messages only sent from paint tasks into a separate PaintMsg enum #8592

Closed
KiChjang opened this issue Nov 18, 2015 · 3 comments
Closed

Comments

@KiChjang
Copy link
Member

@KiChjang KiChjang commented Nov 18, 2015

#8530 introduced different message types that the constellation can receive. Currently there are two message types: CompositorMsg and ScriptMsg. We would like to add a new message type called PaintMsg, which will be used exclusively for paint messages sent by paint_task.rs.

Code: components/msg/constellation_msg.rs, components/compositing/constellation.rs, components/gfx/paint_task.rs

@jdm jdm added the E-easy label Nov 18, 2015
@jdm jdm changed the title Implement ConstellationMsg::PaintMsg Split ScriptMsg messages only sent from paint tasks into a separate PaintMsg enum Nov 18, 2015
@jdm jdm added the I-refactor label Nov 18, 2015
@wldcordeiro
Copy link
Contributor

@wldcordeiro wldcordeiro commented Nov 22, 2015

I'd be interested in trying to tackle this issue.

@KiChjang
Copy link
Member Author

@KiChjang KiChjang commented Nov 22, 2015

Sorry, but a PR has been submitted by @g-k.

g-k added a commit to g-k/servo that referenced this issue Nov 22, 2015
g-k added a commit to g-k/servo that referenced this issue Nov 22, 2015
g-k added a commit to g-k/servo that referenced this issue Nov 22, 2015
g-k added a commit to g-k/servo that referenced this issue Nov 25, 2015
bors-servo added a commit that referenced this issue Nov 25, 2015
Split paint task messages from ScriptMsg

Refs: #8592

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8598)
<!-- Reviewable:end -->
@wafflespeanut
Copy link
Member

@wafflespeanut wafflespeanut commented Nov 28, 2015

fixed by #8598

jrmuizel pushed a commit to jrmuizel/gecko-cinnabar that referenced this issue Jun 12, 2017
…-k:split-scriptmsg); r=KiChjang

Refs: servo/servo#8592
Source-Repo: https://github.com/servo/servo
Source-Revision: 5e7306bf1965988551cafe6a27baab13eb927bbe
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this issue Oct 1, 2019
…-k:split-scriptmsg); r=KiChjang

Refs: servo/servo#8592
Source-Repo: https://github.com/servo/servo
Source-Revision: 5e7306bf1965988551cafe6a27baab13eb927bbe

UltraBlame original commit: 23d1127f43989e8f9be2d9101619e263c06bd867
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this issue Oct 1, 2019
…-k:split-scriptmsg); r=KiChjang

Refs: servo/servo#8592
Source-Repo: https://github.com/servo/servo
Source-Revision: 5e7306bf1965988551cafe6a27baab13eb927bbe

UltraBlame original commit: 23d1127f43989e8f9be2d9101619e263c06bd867
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this issue Oct 1, 2019
…-k:split-scriptmsg); r=KiChjang

Refs: servo/servo#8592
Source-Repo: https://github.com/servo/servo
Source-Revision: 5e7306bf1965988551cafe6a27baab13eb927bbe

UltraBlame original commit: 23d1127f43989e8f9be2d9101619e263c06bd867
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants
You can’t perform that action at this time.