servo / servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parse inline Element styles (div style="display:none") #86

Closed

burg opened this issue Sep 22, 2012 · 3 comments

Labels

A-content/css A-content/dom A-content/parsers I-enhancement

burg commented Sep 22, 2012

The parser should recognize inline styles from the "style" attribute as CSS and lex/parse them, storing the stylesheet somewhere that's accessible during style cascading.

Contributor

bzbarsky commented Sep 22, 2012

We should do this as part of the attribute setter, not in the parser in general, because we have to handle setAttribute("style", "whatever") as well.

sanxiyn mentioned this issue

Pass acid1 #266

Closed

Member

SimonSapin commented Aug 6, 2013

Because "inline" is overloaded with display: inline, CSS specs call this "style attributes".

metajack added a commit to metajack/servo that referenced this issue


        Implement support for style attributes.

7711b9d

If a style attribute is given for a node, it is parsed and attached to the
Element. When selector matching runs on the Element, the style attribute's
stylesheet is passed in.

Fixes servo#86.

metajack mentioned this issue

Implement support for style attributes. #678

Merged

bors-servo pushed a commit that referenced this issue


        auto merge of #678 : metajack/servo/style-attributes, r=jdm

bfecd74

If a style attribute is given for a node, it is parsed and attached to the
Element. When selector matching runs on the Element, the style attribute's
stylesheet is passed in.

Fixes #86.

bors-servo pushed a commit that referenced this issue


        auto merge of #678 : metajack/servo/style-attributes, r=jdm

b017785

If a style attribute is given for a node, it is parsed and attached to the
Element. When selector matching runs on the Element, the style attribute's
stylesheet is passed in.

Fixes #86.

metajack closed this in

4d71918

recrack added a commit to recrack/servo that referenced this issue


        Implement support for style attributes.

5dc3137

If a style attribute is given for a node, it is parsed and attached to the
Element. When selector matching runs on the Element, the style attribute's
stylesheet is passed in.

Fixes servo#86.

recrack added a commit to recrack/servo that referenced this issue


        Implement support for style attributes.

8a7048c

If a style attribute is given for a node, it is parsed and attached to the
Element. When selector matching runs on the Element, the style attribute's
stylesheet is passed in.

Fixes servo#86.

recrack added a commit to recrack/servo that referenced this issue


        Implement support for style attributes.

9cc16b8

If a style attribute is given for a node, it is parsed and attached to the
Element. When selector matching runs on the Element, the style attribute's
stylesheet is passed in.

Fixes servo#86.

recrack added a commit to recrack/servo that referenced this issue


        Implement support for style attributes.

f5e56ad

If a style attribute is given for a node, it is parsed and attached to the
Element. When selector matching runs on the Element, the style attribute's
stylesheet is passed in.

Fixes servo#86.

recrack added a commit to recrack/servo that referenced this issue


        Implement support for style attributes.

180d554

If a style attribute is given for a node, it is parsed and attached to the
Element. When selector matching runs on the Element, the style attribute's
stylesheet is passed in.

Fixes servo#86.

recrack added a commit to recrack/servo that referenced this issue


        Implement support for style attributes.

e1f1c02

If a style attribute is given for a node, it is parsed and attached to the
Element. When selector matching runs on the Element, the style attribute's
stylesheet is passed in.

Fixes servo#86.

june0cho added a commit to june0cho/servo that referenced this issue


        Implement support for style attributes.

23131d6

If a style attribute is given for a node, it is parsed and attached to the
Element. When selector matching runs on the Element, the style attribute's
stylesheet is passed in.

Fixes servo#86.

Contributor

metajack commented Aug 8, 2013

@bzbarsky I didn't read your comment before I did this work. I'll open a new bug to move from the parser to the setter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

You can’t perform that action at this time.