Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Browser API: implement iframe.reload() #8618

Merged
merged 1 commit into from Dec 17, 2015
Merged

Browser API: implement iframe.reload() #8618

merged 1 commit into from Dec 17, 2015

Conversation

paulrouget
Copy link
Contributor

fixes #8575

The implementation is naive, and doesn't support the hardreload parameter.
And for the test, I'm not sure how else I can test the reload.

Review on Reviewable

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Nov 20, 2015
@jdm
Copy link
Member

jdm commented Nov 20, 2015

Is there a spec for how this is supposed to behave? Is it supposed to reload the current contents of the iframe, or reload the url specified by the src attribute?

@paulrouget
Copy link
Contributor Author

It's supposed to reload the current contents of the iframe… and now I realize that this code reloads the src attribute :)

@jdm jdm added S-needs-code-changes Changes have not yet been made that were requested by a reviewer. and removed S-awaiting-review There is new code that needs to be reviewed. labels Nov 20, 2015
@jdm jdm self-assigned this Nov 20, 2015
@highfive highfive added S-awaiting-review There is new code that needs to be reviewed. and removed S-needs-code-changes Changes have not yet been made that were requested by a reviewer. labels Dec 8, 2015
@jdm
Copy link
Member

jdm commented Dec 17, 2015

@bors-servo: r+
Changes look good to me. Thanks!

@bors-servo
Copy link
Contributor

📌 Commit 2a86f9d has been approved by jdm

@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Dec 17, 2015
@bors-servo
Copy link
Contributor

⌛ Testing commit 2a86f9d with merge 9570b51...

bors-servo pushed a commit that referenced this pull request Dec 17, 2015
Auto merge of #8618 - paulrouget:reload, r=jdm
9570b51 
Browser API: implement iframe.reload()

fixes #8575

The implementation is naive, and doesn't support the `hardreload` parameter.
And for the test, I'm not sure how else I can test the reload.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8618)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

⛄ The build was interrupted to prioritize another pull request.

@bors-servo
Copy link
Contributor

⚡ Previous build results for gonk, linux-dev, linux-rel, mac-dev-ref-unit, mac-rel-wpt are reusable. Rebuilding only android, mac-rel-css...

@bors-servo
Copy link
Contributor

⛄ The build was interrupted to prioritize another pull request.

@bors-servo
Copy link
Contributor

⚡ Previous build results for android, gonk, linux-dev, linux-rel, mac-dev-ref-unit, mac-rel-wpt are reusable. Rebuilding only mac-rel-css...

@bors-servo
Copy link
Contributor

☀️ Test successful - android, gonk, linux-dev, linux-rel, mac-dev-ref-unit, mac-rel-css, mac-rel-wpt

@bors-servo bors-servo merged commit 2a86f9d into servo:master Dec 17, 2015
This was referenced Dec 17, 2015
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jdm jdm

Labels
S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Browser API: implement iframe.reload()
4 participants
@paulrouget @jdm @bors-servo @highfive