Implement all webdriver commands.

[Ms2ger]

Specification is at https://w3c.github.io/webdriver/webdriver-spec.html

[Ms2ger]

• AcceptAlert
• AddCookie(AddCookieParameters)
• Close
• DeleteCookies #23006
• DeleteCookie(String)
• DeleteSession
• DismissAlert
• ElementClear(WebElement)
• ElementClick(WebElement)
• ElementTap(WebElement)
• FindElementElements(WebElement, LocatorParameters)
• FindElementElement(WebElement, LocatorParameters)
• GetAlertText
• GetCookies
• GetCookie(String)
• GetCSSValue(WebElement, String)
• GetElementRect(WebElement)
• GetWindowSize #8661
• IsDisplayed(WebElement)
• IsEnabled(WebElement) #8661
• IsSelected(WebElement) #8661
• MaximizeWindow
• SendAlertText(SendAlertTextParameters)
• SetWindowSize(WindowSizeParameters) #11179
• SwitchToWindow(SwitchToWindowParameters)

[craftytrickster]

Is it safe to say that servo/components/webdriver_traits/lib.rs should be deleted since it seems to be a duplicate of servo/components/msg/webdriver_msg.rs and I do not see any usages of it?

[jdm]

Yep!

[craftytrickster]

I would like to try the following four:

GetWindowSize
IsDisplayed(WebElement)
IsEnabled(WebElement)
IsSelected(WebElement) 

However, if possible, I do have a few questions:
Getting a reference to the web element seems easy enough, I can copy what is being done in webdriver_handlers.rs, for example in the handle_get_name function. However, once I have it, do I have to check get_enabled_state for isEnabled and get_focus_state for isSelected? What would the check for isDisplayed?

Also, I created a branch with a commit to implement the GetWindowSize, but I am not sure how to correctly convert the WindowSizeData to a correct WebDriverResponse. Does anyone have a suggestion?
craftytrickster@5c2e3e3#diff-a1d91ab451658c0134bb24f8f406dccbR360

I'd appreciate the help, thank you.

[jdm]

https://w3c.github.io/webdriver/webdriver-spec.html#h-element-displayedness seems relevant for the first question.

[jdm]

As for selected, https://w3c.github.io/webdriver/webdriver-spec.html#is-element-selected .

[jdm]

And the window size response should be constructed according to https://w3c.github.io/webdriver/webdriver-spec.html#dfn-get-window-size .

[craftytrickster]

@jdm thanks!

[jgraham]

Yeah, don't implement IsDisplayed. There isn't a correct way to do that at the moment (or possibly ever), and so we are pushing the application-specific approximation into the client for now.

[craftytrickster]

Do the alert items such as GetAlertText only deal with alerts or do they also deal confirm/prompt alerts as well? I ask because I only see Alert on the window methods, I do not see any mention of confirm/prompt. Should confirm/prompt be ignored for now?

Edit: After looking at this some more, it seems to me that only SendAlertText is possible with the current window api available.

[Ms2ger]

confirm/prompt aren't implemented, and probably won't be for quite a while, so do ignore them.

[dlrobertson]

I'd like to take a crack at this! If it is okay with everyone, I have an idea as to where to start with GetElementRect, so I'd like to start with it.

Let me know at dlr on #servo if you have any tips or if you have an aversion to me trying this (I'm 100% okay with doing something different if so). If not, I'll probably have my first attempt at a PR sometime this evening.

[jdm]

Please do! You can test this by running servo with --webdriver [port_number] and playing with the python webdriver client in tests/wpt/harness/wptrunner/executors/webdriver.py.

[asajeffrey]

#11179 implements SetWindowSize.

[asajeffrey]

A couple of related issues: #11254 (support webdriver actions) and #11253 (support webdriver sessions).

[dlrobertson]

#10826 implements AddCookie, GetCookie, and GetCookies and has been rebased.