Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Document#{elementFromPoint,elementsFromPoint}. #8666

Closed
Ms2ger opened this issue Nov 24, 2015 · 5 comments
Closed

Implement Document#{elementFromPoint,elementsFromPoint}. #8666

Ms2ger opened this issue Nov 24, 2015 · 5 comments
Labels
A-content/dom C-assigned E-easy I-enhancement

Comments

@Ms2ger
Copy link
Contributor

@Ms2ger Ms2ger commented Nov 24, 2015

Spec: https://drafts.csswg.org/cssom-view/#dom-document-elementsfrompoint.
Test: tests/wpt/web-platform-tests/cssom-view/elementFromPoint.html, tests/wpt/web-platform-tests/cssom-view/elementsFromPoint.html.
Code: components/script/dom/document.rs, components/script/dom/webidls/Document.webidl.

This will probably need to call hit_test or get_nodes_under_mouse. It's likely those functions are not quite correct; fixing that is out of scope for this issue.
@rilut
Copy link
Contributor

@rilut rilut commented Nov 24, 2015

I would like to try this, but can I ask you during the development?
@rilut
Copy link
Contributor

@rilut rilut commented Nov 24, 2015

By the way, where is the code/variable for getting viewport height?
@Ms2ger
Copy link
Contributor Author

@Ms2ger Ms2ger commented Nov 24, 2015

I'm afraid this is not code I know well, but feel free to join the IRC channel and we can try to help you out.
@jdm jdm added the C-assigned label Nov 24, 2015
@rilut rilut mentioned this issue Dec 11, 2015
Merged
bors-servo added a commit that referenced this issue Jan 15, 2016
@bors-servo
Auto merge of #8932 - rilut:add-elementfrompoint, r=<try>
e74b436 
Implement Document#elementFromPoint

Related to #8666. I haven't implemented elementsFromPoint, because from my past discussion with jdm, [it's not good yet](https://github.com/rilut/servo/commit/dbfa25214b2888dda7527d62b5df1bb61f1ab047#commitcomment-14668959) to implement elementsFromPoint because it may cause GC hazards.

By the way, I also have to include the test for this, right? I've found this [1]. So, is all I have to do is just to put this into `tests/wpt/web-platform-tests/cssom-view/elementFromPoint.html`?

[1] http://test.csswg.org/suites/cssom-view-1_dev/nightly-unstable/html/elementFromPosition.htm

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8932)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue Jan 15, 2016
@bors-servo
Auto merge of #8932 - rilut:add-elementfrompoint, r=<try>
2c2d333 
Implement Document#elementFromPoint

Related to #8666. I haven't implemented elementsFromPoint, because from my past discussion with jdm, [it's not good yet](https://github.com/rilut/servo/commit/dbfa25214b2888dda7527d62b5df1bb61f1ab047#commitcomment-14668959) to implement elementsFromPoint because it may cause GC hazards.

By the way, I also have to include the test for this, right? I've found this [1]. So, is all I have to do is just to put this into `tests/wpt/web-platform-tests/cssom-view/elementFromPoint.html`?

[1] http://test.csswg.org/suites/cssom-view-1_dev/nightly-unstable/html/elementFromPosition.htm

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8932)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue Feb 4, 2016
@bors-servo
Auto merge of #8932 - rilut:add-elementfrompoint, r=<try>
1438322 
Implement Document#elementFromPoint

Related to #8666. I haven't implemented elementsFromPoint, because from my past discussion with jdm, [it's not good yet](https://github.com/rilut/servo/commit/dbfa25214b2888dda7527d62b5df1bb61f1ab047#commitcomment-14668959) to implement elementsFromPoint because it may cause GC hazards.

By the way, I also have to include the test for this, right? I've found this [1]. So, is all I have to do is just to put this into `tests/wpt/web-platform-tests/cssom-view/elementFromPoint.html`?

[1] http://test.csswg.org/suites/cssom-view-1_dev/nightly-unstable/html/elementFromPosition.htm

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8932)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue Feb 5, 2016
@bors-servo
Auto merge of #8932 - rilut:add-elementfrompoint, r=<try>
bdabc83 
Implement Document#elementFromPoint

Related to #8666. I haven't implemented elementsFromPoint, because from my past discussion with jdm, [it's not good yet](https://github.com/rilut/servo/commit/dbfa25214b2888dda7527d62b5df1bb61f1ab047#commitcomment-14668959) to implement elementsFromPoint because it may cause GC hazards.

By the way, I also have to include the test for this, right? I've found this [1]. So, is all I have to do is just to put this into `tests/wpt/web-platform-tests/cssom-view/elementFromPoint.html`?

[1] http://test.csswg.org/suites/cssom-view-1_dev/nightly-unstable/html/elementFromPosition.htm

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8932)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue Feb 26, 2016
@bors-servo
Auto merge of #8932 - rilut:add-elementfrompoint, r=<try>
ab1e88f 
Implement Document#elementFromPoint

Related to #8666. I haven't implemented elementsFromPoint, because from my past discussion with jdm, [it's not good yet](https://github.com/rilut/servo/commit/dbfa25214b2888dda7527d62b5df1bb61f1ab047#commitcomment-14668959) to implement elementsFromPoint because it may cause GC hazards.

By the way, I also have to include the test for this, right? I've found this [1]. So, is all I have to do is just to put this into `tests/wpt/web-platform-tests/cssom-view/elementFromPoint.html`?

[1] http://test.csswg.org/suites/cssom-view-1_dev/nightly-unstable/html/elementFromPosition.htm

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8932)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue Feb 26, 2016
@bors-servo
Auto merge of #8932 - rilut:add-elementfrompoint, r=nox
4f6d460 
Implement Document#elementFromPoint

Related to #8666. I haven't implemented elementsFromPoint, because from my past discussion with jdm, [it's not good yet](https://github.com/rilut/servo/commit/dbfa25214b2888dda7527d62b5df1bb61f1ab047#commitcomment-14668959) to implement elementsFromPoint because it may cause GC hazards.

By the way, I also have to include the test for this, right? I've found this [1]. So, is all I have to do is just to put this into `tests/wpt/web-platform-tests/cssom-view/elementFromPoint.html`?

[1] http://test.csswg.org/suites/cssom-view-1_dev/nightly-unstable/html/elementFromPosition.htm

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8932)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue Feb 27, 2016
@bors-servo
Auto merge of #8932 - rilut:add-elementfrompoint, r=nox
331308d 
Implement Document#elementFromPoint

Related to #8666. I haven't implemented elementsFromPoint, because from my past discussion with jdm, [it's not good yet](https://github.com/rilut/servo/commit/dbfa25214b2888dda7527d62b5df1bb61f1ab047#commitcomment-14668959) to implement elementsFromPoint because it may cause GC hazards.

By the way, I also have to include the test for this, right? I've found this [1]. So, is all I have to do is just to put this into `tests/wpt/web-platform-tests/cssom-view/elementFromPoint.html`?

[1] http://test.csswg.org/suites/cssom-view-1_dev/nightly-unstable/html/elementFromPosition.htm

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8932)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue Feb 29, 2016
@bors-servo
Auto merge of #8932 - rilut:add-elementfrompoint, r=nox
Loading status checks…
4bcdbe6 
Implement Document#elementFromPoint

Related to #8666. I haven't implemented elementsFromPoint, because from my past discussion with jdm, [it's not good yet](https://github.com/rilut/servo/commit/dbfa25214b2888dda7527d62b5df1bb61f1ab047#commitcomment-14668959) to implement elementsFromPoint because it may cause GC hazards.

By the way, I also have to include the test for this, right? I've found this [1]. So, is all I have to do is just to put this into `tests/wpt/web-platform-tests/cssom-view/elementFromPoint.html`?

[1] http://test.csswg.org/suites/cssom-view-1_dev/nightly-unstable/html/elementFromPosition.htm

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8932)
<!-- Reviewable:end -->
@KiChjang
Copy link
Member

@KiChjang KiChjang commented Mar 3, 2016

Fixed by #8932.
@KiChjang KiChjang closed this Mar 3, 2016
@jdm
Copy link
Member

@jdm jdm commented Mar 3, 2016

We should file a new issue for elementsFromPoint, since it's now possible to implement safely.
@rilut rilut mentioned this issue Mar 3, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-content/dom C-assigned E-easy I-enhancement
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
@jdm @Ms2ger @rilut @KiChjang
You can’t perform that action at this time.