Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Intermittent timeout in /_mozilla/css/iframe/hide_layers2.html (Constellation panic) #8769

Closed
jdm opened this issue Dec 1, 2015 · 7 comments
Closed

Intermittent timeout in /_mozilla/css/iframe/hide_layers2.html (Constellation panic) #8769

jdm opened this issue Dec 1, 2015 · 7 comments
Labels
I-intermittent I-panic

Comments

@jdm
Copy link
Member

@jdm jdm commented Dec 1, 2015 

▶ TIMEOUT [expected PASS] /_mozilla/css/iframe/hide_layers2.html
  │ 
  │ thread 'Constellation' panicked at 'unable to find pipeline - this is a bug', ../src/libcore/option.rs:335
  │ stack backtrace:
  │    1:        0x10d215d08 - sys::backtrace::tracing::imp::write::h3ed615ef3cda9b6b7It
  │    2:        0x10d217e4f - panicking::log_panic::_<closure>::closure.40650
  │    3:        0x10d2178f2 - panicking::log_panic::hdfd4a4ec7b55d6a5MAx
  │    4:        0x10d202de6 - sys_common::unwind::begin_unwind_inner::h2f70decd24e7a2917Ls
  │    5:        0x10d2031ce - sys_common::unwind::begin_unwind_fmt::h29da0d611b24747ddLs
  │    6:        0x10d215327 - rust_begin_unwind
  │    7:        0x10d23a430 - panicking::panic_fmt::h2f3428e3725b99d6VFK
  │    8:        0x10bc3e62d - constellation::_<impl>::handle_request::handle_request::h17802158443733694633
  │    9:        0x10bc23aa7 - sys_common::unwind::try::try_fn::try_fn::h5102255439231410249
  │   10:        0x10d215148 - __rust_try
  │   11:        0x10d21224e - sys_common::unwind::try::inner_try::hd7e4f8fc422767d2FIs
  │   12:        0x10bc25b6a - boxed::_<impl>::call_box::call_box::h3181868436741623310
  │   13:        0x10d2170dd - sys::thread::_<impl>::new::thread_start::ha2c46efb1706c462jVw
  │   14:     0x7fff91449059 - _pthread_body
  └   15:     0x7fff91448fd6 - _pthread_start
This was referenced Dec 1, 2015
Merged
Merged
@Ms2ger Ms2ger mentioned this issue Dec 3, 2015
Merged
This was referenced Dec 3, 2015
Merged
Merged
@KiChjang KiChjang mentioned this issue Dec 3, 2015
Merged
@mrobinson mrobinson mentioned this issue Dec 7, 2015
Merged
This was referenced Dec 8, 2015
Merged
Merged
This was referenced Dec 11, 2015
Merged
Merged
@jdm jdm mentioned this issue Dec 17, 2015
Merged
@KiChjang KiChjang mentioned this issue Dec 18, 2015
Merged
@mrobinson mrobinson mentioned this issue Dec 28, 2015
Merged
@larsbergstrom larsbergstrom mentioned this issue Dec 30, 2015
Merged
This was referenced Dec 31, 2015
Merged
Merged
This was referenced Jan 3, 2016
Merged
Merged
@mbrubeck mbrubeck mentioned this issue Jan 6, 2016
Merged
@jdm jdm mentioned this issue Jan 6, 2016
Merged
This was referenced Jan 7, 2016
Merged
Merged
Merged
Merged
@Ms2ger Ms2ger mentioned this issue Jan 8, 2016
Merged
@jdm jdm mentioned this issue Jan 8, 2016
Merged
@nox nox mentioned this issue Jan 8, 2016
Merged
bors-servo added a commit that referenced this issue Mar 31, 2016
@bors-servo
Auto merge of #10082 - asajeffrey:remove-constellation-panic, r=glennw
Loading status checks…
7518c4d 
Removed panicking when frame or pipeline lookup fails.

Removed the methods `pipeline(id)`, `pipeline_mut(id)`, `frame(id)` and `frame_mut(id)` from constellation, which panicked when the table lookup failed.

The panics were causing race conditions, e.g. visiting google.com and resizing the page would cause a panic, most likely due to an iframe being added and removed, with the `DOMLoad` event arriving after the iframe had been removed, causing a panic.

This patch fixes #10017 and #8769 (although in non-webrender builds there's now a different panic, see #10017 (comment)).

There are a few `TODO` items in the initial commit, for cases where it's not completely obvious what to do in the case of failure.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10082)
<!-- Reviewable:end -->
@jdm jdm added the C-disabled label Apr 22, 2016
@metajack metajack mentioned this issue Jul 12, 2016
Open
8 of 18 tasks complete
nox added a commit to nox/servo that referenced this issue Aug 10, 2016
@nox
Enable hide_layers2.html (closes servo#8769)
688c0ed 
This was apparently fixed by servo#10082.
bors-servo added a commit that referenced this issue Aug 10, 2016
@bors-servo
Auto merge of #12796 - nox:intermittent, r=jdm
Loading status checks…
dc47e66 
Enable hide_layers2.html (closes #8769)

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12796)
<!-- Reviewable:end -->
@Manishearth Manishearth mentioned this issue Aug 11, 2016
Merged
2 of 3 tasks complete
@jdm
Copy link
Member Author

@jdm jdm commented Aug 11, 2016

Seen in #12795.
@jdm jdm reopened this Aug 11, 2016
@jdm jdm removed the C-disabled label Aug 11, 2016
This was referenced Aug 12, 2016
Merged
Merged
@wafflespeanut wafflespeanut mentioned this issue Aug 14, 2016
Merged
4 of 4 tasks complete
@emilio emilio mentioned this issue Aug 17, 2016
Merged
0 of 5 tasks complete
@emilio
Copy link
Member

@emilio emilio commented Aug 17, 2016

It doesn't seem to have a panic in #12887
@wafflespeanut wafflespeanut mentioned this issue Aug 18, 2016
Merged
@cbrewster cbrewster mentioned this issue Aug 19, 2016
Merged
0 of 5 tasks complete
@glennw glennw mentioned this issue Aug 21, 2016
Merged
0 of 5 tasks complete
@KiChjang KiChjang mentioned this issue Aug 22, 2016
Merged
4 of 4 tasks complete
@Manishearth Manishearth mentioned this issue Aug 23, 2016
Merged
@nox nox mentioned this issue Aug 23, 2016
Closed
2 of 5 tasks complete
@Ms2ger Ms2ger mentioned this issue Aug 26, 2016
Merged
2 of 4 tasks complete
@nox nox mentioned this issue Aug 26, 2016
Merged
@bholley bholley mentioned this issue Aug 26, 2016
Merged
@bholley
Copy link
Contributor

@bholley bholley commented Aug 26, 2016

No panic in #12911 either.
@jdm
Copy link
Member Author

@jdm jdm commented Aug 26, 2016

Let's file a new issue for the non-panicking failure and close this one, since we removed the code that panics.
@jdm
Copy link
Member Author

@jdm jdm commented Aug 26, 2016

Filed #13059.
@jdm jdm closed this Aug 26, 2016
samuknet added a commit to samuknet/servo that referenced this issue Sep 6, 2016
@nox @samuknet
Enable hide_layers2.html (closes servo#8769)
37a114c 
This was apparently fixed by servo#10082.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
I-intermittent I-panic
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
@jdm @bholley @emilio @KiChjang
You can’t perform that action at this time.