Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multiple spaces don't get rendered in input fields #8772

Closed
frewsxcv opened this issue Dec 2, 2015 · 7 comments
Closed

Multiple spaces don't get rendered in input fields #8772

frewsxcv opened this issue Dec 2, 2015 · 7 comments
Assignees
@Manishearth
Labels
A-layout/inline A-layout/text C-assigned I-wrong

Comments

@frewsxcv
Copy link
Member

@frewsxcv frewsxcv commented Dec 2, 2015

Caret issue: #8543

Steps to reproduce:

  1. go to a text field
  2. press space five times
  3. press a letter
  4. notice that visually it looks like only one space was pressed

untitled
@frewsxcv frewsxcv added the I-wrong label Dec 2, 2015
@frewsxcv
Copy link
Member Author

@frewsxcv frewsxcv commented Dec 2, 2015

test case:

<input value="foo     bar">

<input value="foo&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;bar">
@jdm
Copy link
Member

@jdm jdm commented Dec 2, 2015

I bet this is the layout code doing its whitespace collapsing on the generated text.
Manishearth added a commit to Manishearth/servo that referenced this issue Dec 15, 2015
@Manishearth
Avoid whitespace collapse for text inputs (fixes servo#8772)
ef64f88
@Manishearth Manishearth mentioned this issue Dec 15, 2015
Merged
Manishearth added a commit to Manishearth/servo that referenced this issue Jan 2, 2016
@Manishearth
Avoid whitespace collapse for text inputs (fixes servo#8772)
0a9ffcd
Manishearth added a commit to Manishearth/servo that referenced this issue Jan 3, 2016
@Manishearth
Avoid whitespace collapse for text inputs (fixes servo#8772)
46a9c92
@TheKK
Copy link
Contributor

@TheKK TheKK commented Jan 6, 2016

Hi, can I take this one :)
@KiChjang
Copy link
Member

@KiChjang KiChjang commented Jan 6, 2016

Yes, please do :)
@KiChjang KiChjang added the C-assigned label Jan 6, 2016
@frewsxcv
Copy link
Member Author

@frewsxcv frewsxcv commented Jan 6, 2016

@TheKK: I think @Manishearth already has this completed in #8983, though it hasn't merged yet
@TheKK
Copy link
Contributor

@TheKK TheKK commented Jan 6, 2016

Yup, this was fixed. I'll find something else I can work on.
@Manishearth Manishearth self-assigned this Jan 6, 2016
bors-servo added a commit that referenced this issue Jan 7, 2016
@bors-servo
Auto merge of #8983 - Manishearth:cursors, r=jdm
9d4cb85 
Various textinput fixes

 - Currently the cursor sticks around if you click elsewhere. Now the text inputs are relayout-ed on blur.
 - Currently whitespace gets collapsed in text input (#8772). Not anymore.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8983)
<!-- Reviewable:end -->
@Manishearth
Copy link
Member

@Manishearth Manishearth commented Jan 11, 2016

#8983
bors-servo added a commit that referenced this issue Jan 11, 2016
@bors-servo
Auto merge of #8983 - Manishearth:cursors, r=jdm
63251f1 
Various textinput fixes

 - Currently the cursor sticks around if you click elsewhere. Now the text inputs are relayout-ed on blur.
 - Currently whitespace gets collapsed in text input (#8772). Not anymore.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8983)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue Jan 11, 2016
@bors-servo
Auto merge of #8983 - Manishearth:cursors, r=jdm
dbc2c2f 
Various textinput fixes

 - Currently the cursor sticks around if you click elsewhere. Now the text inputs are relayout-ed on blur.
 - Currently whitespace gets collapsed in text input (#8772). Not anymore.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8983)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue Jan 11, 2016
@bors-servo
Auto merge of #8983 - Manishearth:cursors, r=jdm
Loading status checks…
099beee 
Various textinput fixes

 - Currently the cursor sticks around if you click elsewhere. Now the text inputs are relayout-ed on blur.
 - Currently whitespace gets collapsed in text input (#8772). Not anymore.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8983)
<!-- Reviewable:end -->
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this issue Oct 1, 2019
@marco-c
servo: Merge #8983 - Various textinput fixes (from Manishearth:cursor…
d9134c7 
…s); r=jdm

 - Currently the cursor sticks around if you click elsewhere. Now the text inputs are relayout-ed on blur.
 - Currently whitespace gets collapsed in text input (servo/servo#8772). Not anymore.

Source-Repo: https://github.com/servo/servo
Source-Revision: 099beee85c02d391b854dc5e06da34f89df8b760

UltraBlame original commit: 58c8a4d14f6c2e8f27cb76b280ec8a27fc15dc10
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this issue Oct 1, 2019
@marco-c
servo: Merge #8983 - Various textinput fixes (from Manishearth:cursor…
3b5e28c 
…s); r=jdm

 - Currently the cursor sticks around if you click elsewhere. Now the text inputs are relayout-ed on blur.
 - Currently whitespace gets collapsed in text input (servo/servo#8772). Not anymore.

Source-Repo: https://github.com/servo/servo
Source-Revision: 099beee85c02d391b854dc5e06da34f89df8b760

UltraBlame original commit: 58c8a4d14f6c2e8f27cb76b280ec8a27fc15dc10
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this issue Oct 1, 2019
@marco-c
servo: Merge #8983 - Various textinput fixes (from Manishearth:cursor…
6162c9b 
…s); r=jdm

 - Currently the cursor sticks around if you click elsewhere. Now the text inputs are relayout-ed on blur.
 - Currently whitespace gets collapsed in text input (servo/servo#8772). Not anymore.

Source-Repo: https://github.com/servo/servo
Source-Revision: 099beee85c02d391b854dc5e06da34f89df8b760

UltraBlame original commit: 58c8a4d14f6c2e8f27cb76b280ec8a27fc15dc10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Manishearth Manishearth

Labels
A-layout/inline A-layout/text C-assigned I-wrong
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants
@jdm @frewsxcv @Manishearth @KiChjang @TheKK
You can’t perform that action at this time.