Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loaded events trigger on failed HTTP requests #8819

Open
alex opened this issue Dec 4, 2015 · 6 comments
Open

Loaded events trigger on failed HTTP requests #8819

alex opened this issue Dec 4, 2015 · 6 comments
Labels

Comments

@alex
Copy link
Contributor

@alex alex commented Dec 4, 2015

I'm not quite sure which APIs cause this issue, but here is the symptom:

This is because some browser API is reporting a success, even though the HTTPS request failed (correctly).

@jdm
Copy link
Member

@jdm jdm commented Dec 4, 2015

I suspect this is caused by the problems that #8678 is intended to fix. That is, presumably the connections are blocked but the resulting error page is treated as a valid network response by the listeners.

@jdm jdm added the A-network label Dec 4, 2015
@alex
Copy link
Contributor Author

@alex alex commented Dec 4, 2015

Sounds totally plausible!

@alex
Copy link
Contributor Author

@alex alex commented Jun 5, 2017

I suspect this is a dupe of #1719, but not positive

@nox
Copy link
Member

@nox nox commented Sep 30, 2017

This was fixed, AFAIK.

@nox nox closed this Sep 30, 2017
@alex
Copy link
Contributor Author

@alex alex commented Sep 30, 2017

@nox I don't think so, https://badssl.com/dashboard/ shows every single result as connected - no error events fired.

@nox
Copy link
Member

@nox nox commented Sep 30, 2017

Oh, misread it. Thanks for the quick reaction.

@nox nox reopened this Sep 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.